test(rabbitmq): declare exchange and queue as durable#1037
Open
Tranquility2 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 83.29% 83.29%
=======================================
Files 16 16
Lines 1754 1754
Branches 193 193
=======================================
Hits 1461 1461
Misses 236 236
Partials 57 57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
can you guys coordinate? @CarliJoy? - I'm trying my best not to merge any PRs until after the src layout migration which i greenlit because the only other long standing PR which is strongly desired is the reusable containers one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_docker_run_rabbitmqfails on all 4 parametrized cases againstrabbitmq:latest(currently 4.x):The earlier
IncompatibleProtocolError/StreamLostErrorlines in CI logs were a downstream symptom of the broker dropping the connection after the rejected queue declaration.Fix
Declare both the exchange and the queue as
durable=True. RabbitMQ 4.x disallows transient non-exclusive queues by default; durable is the supported replacement and is appropriate for an integration test that publishes/consumes a single message.Verification
uv run pytest -q modules/rabbitmq/tests/test_rabbitmq.py— 4 passed locally againstrabbitmq:latest.