Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions projects/testing-library/src/lib/testing-library.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,16 @@ export async function render<SutType, WrapperType = SutType>(
defaultImports = [],
} = { ...globalConfig, ...renderOptions };

dtlConfigure(domConfig);
dtlConfigure({
eventWrapper: (cb) => {
const result = cb();
if (autoDetectChanges) {
detectChangesForMountedFixtures();
}
return result;
},
...domConfig,
});

TestBed.configureTestingModule({
declarations: addAutoDeclarations(sut, {
Expand Down Expand Up @@ -183,6 +192,7 @@ export async function render<SutType, WrapperType = SutType>(
result = doNavigate();
}

detectChanges();
return result ?? false;
};

Expand Down Expand Up @@ -234,10 +244,6 @@ export async function render<SutType, WrapperType = SutType>(
fixture.componentInstance.ngOnChanges(changes);
}

if (autoDetectChanges) {
fixture.autoDetectChanges(true);
}

detectChanges = () => {
if (isAlive) {
fixture.detectChanges();
Expand Down
17 changes: 17 additions & 0 deletions projects/testing-library/tests/issues/issue-346.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { Component } from '@angular/core';
import { render } from '../../src/public_api';

test('issue 364 detectChangesOnRender', async () => {
@Component({
selector: 'atl-fixture',
template: `{{ myObj.myProp }}`,
})
class MyComponent {
myObj: any = null;
}

// autoDetectChanges invokes change detection, which makes the test fail
await render(MyComponent, {
detectChangesOnRender: false,
});
});