Conversation
|
Thanks for this @benmccann but we're currently not willing to remove the pin. aria-query aren't following semantic versioning tightly and every minor change which seems like an addition on their end might break existing tests for users of testing-library. |
|
Can we reopen this and do the upgrade without the pin? |
|
Every upgrade we do to aria-query requires several checks based on aria-query's release notes to verify if there were any changes that might cause a breaking change to our users. |
|
5.3.2 is certainly not breaking and 5.3.1 has only a few changes: https://github.com/A11yance/aria-query/blob/main/CHANGELOG.md#531 I'm unsure of what types of changes have caused users of this project problems in the past. We use this library in Svelte and would be fine to upgrade based on the changelog, but I'm not exactly sure how the library is used here and if these changes would be considered safe or not. |
What:
Unpin
aria-queryWhy:
I have multiple versions of
aria-queryin my project. This allows it to dedupeHow:
See #1341 (comment) for a discussion of why the CI is failing. It would be nice to merge that PR and then add a lockfile to this project
Checklist:
docs site - N/A