fix: add missing prettyDOM export to typings file#109
Merged
kentcdodds merged 1 commit intotesting-library:masterfrom Jun 8, 2018
Merged
Conversation
* exports `prettyDOM` from dom-testing-library in the react-testing-library's typings file.
Contributor
Author
|
Not sure what's up with all those diffs in the README... |
Member
|
I think it may have to do with prettier or some other sort of markdown auto formatter. Recently I noticed another PR that changed all the bullet lists in markdown from using |
kentcdodds
approved these changes
Jun 8, 2018
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
This is good. It looks like that's what prettier does now
Member
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prettyDOMfrom dom-testing-library in thereact-testing-library's typings file.
Fixes: #108
What: adds an export for
prettyDOMin react-testing-library's typing's file.Why: to prevent the Typescript compiler from erroring.
How: an export line was added to the react-testing-library's typing's file.
Checklist: