export RenderResult interface#113
Merged
kentcdodds merged 2 commits intotesting-library:masterfrom Jun 12, 2018
knalinne:master
Merged
export RenderResult interface#113kentcdodds merged 2 commits intotesting-library:masterfrom knalinne:master
kentcdodds merged 2 commits intotesting-library:masterfrom
knalinne:master
Conversation
pbomb
approved these changes
Jun 12, 2018
Collaborator
pbomb
left a comment
pbomb
left a comment
There was a problem hiding this comment.
This change looks good to me. I'm not sure why TypeScript has let me be able to import this type in my code, but exporting it makes more sense. 👍
kentcdodds
added
the
TypeScript
Member
|
🎉 This PR is included in version 3.1.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
Closes testing-library#112 <!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated! Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file). Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! --> <!-- What changes are being made? (What feature/bug is being fixed here?) --> **What**: Fixes typings <!-- Why are these changes necessary? --> **Why**: Redundant letter in variable names <!-- How were these changes implemented? --> **How**: Remove redundant letters <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation N/A - [ ] Tests N/A - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Export the RenderResult interface from typings
fix: #112
Why:
RenderResult can now be imported in tests, passed to utility functions.
It also fix the typescript compiler
How:
An export keyword has been added in the typings file
Checklist: