fix(TS): Add missing getAll and queryAll functions to TS definitions#88
Merged
kentcdodds merged 1 commit intotesting-library:masterfrom May 18, 2018
Merged
Conversation
Member
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Collaborator
Author
|
Thanks, Kent! |
Member
|
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
Collaborator
Author
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Adds missing TypeScript definitions for the getAll* and queryAll* functions. Also adds type definition for re-exported
getQueriesForElementfunction.Why:
These additions more accurately reflect what the library does and they're helpful. I found that I could get rid of some calls to
querySelectorAllin favor ofqueryAllByTestIdin my tests, which was more convenient.How:
Imported and reused the TS definitions from dom-testing-library to bind the get/query functions to the dom element.
Checklist: