Fixed tests on OpenBSD

[ston1th]

Since OpenBSD 6.0 W^X is enforced.
Added RANDOMX_FLAG_SECURE in tests and benchmarks.

Excluded cpu_set_t since it is not defined on OpenBSD.

[tevador]

Do all tests pass on OpenBSD?

[ston1th]

Yes they do.
Except for the AVX2 test, which is skipped because I do not have the required hardware.

[tevador]

I'm thinking to add RANDOMX_FLAG_SECURE to randomx_get_flags on OpenBSD, since the purpose of this function is to return flags that will work 100% on the target system. I think if you try mining in monerod it will fail even with this patch.

RandomX/src/randomx.cpp

Lines 42 to 55 in 4296c35

	randomx_flags randomx_get_flags() {
	randomx_flags flags = RANDOMX_HAVE_COMPILER ? RANDOMX_FLAG_JIT : RANDOMX_FLAG_DEFAULT;
	randomx::Cpu cpu;
	if (HAVE_AES && cpu.hasAes()) {
	flags |= RANDOMX_FLAG_HARD_AES;
	}
	if (randomx_argon2_impl_avx2() != nullptr && cpu.hasAvx2()) {
	flags |= RANDOMX_FLAG_ARGON2_AVX2;
	}
	if (randomx_argon2_impl_ssse3() != nullptr && cpu.hasSsse3()) {
	flags |= RANDOMX_FLAG_ARGON2_SSSE3;
	}
	return flags;
	}

[ston1th]

Good idea. I updated the patch to account for this.

Despite the point I don't think OpenBSD is a system to mine efficiently on :)

[tevador]

@ston1th Please also update the comment here

RandomX/src/randomx.h

Line 84 in e0484df

* RANDOMX_FLAG_SECURE

It should say that it sets the flag on OpenBSD because it's enforced by the OS.

[jtgrassie]

What's wrong with this on OpenBSD?

[jtgrassie]

Nvm, I missed your comment.

[SChernykh]

This should actually be rewritten for OpenBSD: https://man.openbsd.org/NetBSD-7.0.1/affinity.3
Struct name is cpuset_t there.

[ston1th]

I may be mistaken but you are referring to a man page of NetBSD.
I can't find either one of these in the OpenBSD sources: cpu_set_t, cpuset_t, CPU_ZERO, CPU_SET.

I think there is no thread affinity for OpenBSD: https://man.openbsd.org/pthreads.3

[SChernykh]

Yes, you're right and it seems to be a design decision for OpenBSD.

[SChernykh]

@ston1th
Excluded cpu_set_t since it is not defined on OpenBSD.
Just add #define cpu_set_t cpuset_t for OpenBSD. It should work fine, just the name is different on OpenBSD.

Edit: nvm, OpenBSD doesn't support it.