Preserve floating point state when calling randomx_calculate_hash#182
Merged
Preserve floating point state when calling randomx_calculate_hash#182
Conversation
SChernykh
approved these changes
May 15, 2020
hyc
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically, the floating point registers are nonvolatile in most calling conventions, so we should preserve their values.
Not preserved for
randomx_calculate_hash_{first,next,last}, but I added a warning in their description. These functions typically run in worker threads, so altering the rounding mode should not be a big problem there.