Conversation
Closed
tevador
force-pushed
the
pr-netbsd
branch
2 times, most recently
from
7210184 to
1b5301f
Compare
SChernykh
approved these changes
Jun 28, 2020
Collaborator
|
Could you please provide a more descriptive comment? It looks to me like two separate items are fixed:
Is that correct? |
Owner
Author
|
@hyc It's actually 3 separate changes that are needed to make RandomX work on NetBSD. I have edited the first comment. |
Collaborator
|
Would like that in the actual commit comment, not just this PR comment, thanks. |
1. Disable hugepages (not supported). 2. Force W^X (required). 3. When allocating JIT memory, PROT_EXEC must be reserved in order to set the pages executable later.
Owner
Author
|
Done. |
hyc
approved these changes
Jun 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186