ARM64 JIT: don't use x18 register#281
Merged
SChernykh merged 1 commit intotevador:masterfrom Oct 19, 2023
Merged
Conversation
This was referenced Oct 19, 2023
Contributor
|
|
|
Tested on a M1 and M2. Tests pass.
|
tevador
approved these changes
Oct 19, 2023
hyc
approved these changes
Oct 19, 2023
Collaborator
hyc
left a comment
hyc
left a comment
There was a problem hiding this comment.
Still no problems on M1 Macbook pro running MacOS 12.6.5, build 21G531, clang 13.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms
This PR fixes invalid hashes when running on Apple silicon with the latest macOS SDK.