[Feat] Allow label type annotations for multiple selected boxes & Disallow zooming while in drawing mode#10
Merged
felixdittrich92 merged 4 commits intomainfrom Apr 22, 2025
Conversation
Deselect all annotations before saving
felixdittrich92
requested changes
Apr 14, 2025
Collaborator
felixdittrich92
left a comment
felixdittrich92
left a comment
There was a problem hiding this comment.
Please update the failing tests - the deselect_all before saving breaks the current tests
Added monkeypatch to test_saver to mock deselect_all method.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 80.60% 80.34% -0.26%
==========================================
Files 9 9
Lines 861 870 +9
==========================================
+ Hits 694 699 +5
- Misses 167 171 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felixdittrich92
approved these changes
Apr 14, 2025
felixT2K
changed the title
Contributor
|
felixT2K
reviewed
Apr 17, 2025
| with self.img_cnv.polygons_mutex: | ||
| new_type = self.type_variable.get().strip() | ||
| last_selected_polygon.poly_type = new_type | ||
| # skip if it's the default type |
Contributor
There was a problem hiding this comment.
@t2k-list otherwise we override prev selected with the default
t2k-list
force-pushed
the
bugfix/limit-list-size-deselect-before-save
branch
from
a7b9d4b to
619aa81
Compare
felixdittrich92
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Closes: #8 #11