enable keepalive pinging#263
Merged
Merged
Conversation
Signed-off-by: Aaron Sutula <hi@asutula.com>
sanderpick
reviewed
Jul 8, 2020
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Member
|
I hope you don't mind @asutula, but I added a configurable package constant to tweak this. |
sanderpick
reviewed
Jul 8, 2020
Member
Author
|
So, how does that variable get set if someone wants to change it @carsonfarmer? I guess there would some flags at the cli cmd level, that would filter down to set that var? |
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Member
|
Based on my understanding, we could tweak it (now that its exported) from |
Member
Author
|
Ok, I'll merge it and we can address the flags thing potentially in another PR if we decide it's needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Sutula hi@asutula.com