Skip to content

enable keepalive pinging#263

Merged
asutula merged 3 commits into
masterfrom
asutula/ws-ping
Jul 8, 2020
Merged

enable keepalive pinging#263
asutula merged 3 commits into
masterfrom
asutula/ws-ping

Conversation

@asutula
Copy link
Copy Markdown
Member

@asutula asutula commented Jul 8, 2020

Signed-off-by: Aaron Sutula hi@asutula.com

Signed-off-by: Aaron Sutula <hi@asutula.com>
@asutula asutula self-assigned this Jul 8, 2020
Comment thread core/core.go Outdated
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
Copy link
Copy Markdown
Member

I hope you don't mind @asutula, but I added a configurable package constant to tweak this.

@carsonfarmer carsonfarmer requested a review from sanderpick July 8, 2020 21:33
Comment thread core/core.go Outdated
@asutula
Copy link
Copy Markdown
Member Author

asutula commented Jul 8, 2020

So, how does that variable get set if someone wants to change it @carsonfarmer? I guess there would some flags at the cli cmd level, that would filter down to set that var?

Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
@carsonfarmer
Copy link
Copy Markdown
Member

carsonfarmer commented Jul 8, 2020

Based on my understanding, we could tweak it (now that its exported) from buckd/main.go and/or hubd/main.go, probs via some flags. Seems like we can leave it to the default for now, as I expect we're unlikely to want to change it? But I defs could be wrong and we could just add it as flags in there?

@asutula
Copy link
Copy Markdown
Member Author

asutula commented Jul 8, 2020

Ok, I'll merge it and we can address the flags thing potentially in another PR if we decide it's needed.

@asutula asutula merged commit 8878961 into master Jul 8, 2020
@asutula asutula deleted the asutula/ws-ping branch July 8, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants