add error details when throwing HydratingException - #12
Open
nguyenk wants to merge 2 commits into
Open
Conversation
Member
|
This PR seems to break the unit tests. Could you fix this? |
Member
Author
|
Yes, done. I had to build errors message recursively. |
moufmouf
reviewed
Nov 12, 2018
moufmouf
left a comment
moufmouf
left a comment
Member
There was a problem hiding this comment.
Could we try this code with a small unit test? This seems untested to me.
| public function __construct($errorsMap, $message = "", $code = 412) | ||
| { | ||
| $errorMessages = $this->getErrorMessage($errorsMap); | ||
| $message .= "Detailed errors : \n " . implode(", ", $errorMessages); |
Member
There was a problem hiding this comment.
Suggested change
| $message .= "Detailed errors : \n " . implode(", ", $errorMessages); | |
| $message .= " - Detailed errors : \n " . implode(", ", $errorMessages); |
Maybe we could add a "dash" before the "Detailed errors" message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11