[Metabuli | Fastp] Init Metabuli standalone workflow#1006
Merged
Conversation
… adapter trimming by default
cimendes
previously approved these changes
Mar 5, 2026
11 tasks
Member
Author
|
Additional testing following merge conflict resolution: |
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 20, 2026
MrTheronJ
reviewed
Mar 21, 2026
MrTheronJ
reviewed
Mar 21, 2026
MrTheronJ
reviewed
Mar 21, 2026
Member
Author
|
Thanks for the great feedback, @MrTheronJ - all requests have been resolved and tests have been relaunched for 5 samples of TheiaViral_ONT and Metabuli standalone: |
Member
Author
|
hardened regex further here (error due to transient URL handshake error unrelated to this PR): |
MrTheronJ
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
Create metabuli standalone workflow to replace kraken2_ont workflow for appropriate long read classification. Metabuli is also compatible with Illumina reads.
As part of this PR, adapter trimming was implemented into the Metabuli workflow, per the software authors' recommendation. Fastp underwent a major release update compared to the previous PHB version, so modifications were made to merge fastp_se and fastp_pe, and toggle adapter trimming akin to task_trimmomatic.
Fastplong (separate software from fastp) was added for ONT trimming
⚡ Impacted Workflows/Tasks
Workflows
+
metabuli_wfΔ
read_QC_trim_peΔ
read_QC_trim_seΔ
theiaviral_illumina_peΔ
theiaviral_ontΔ
theiaviral_panelTasks
+
fastplongΔ
fastpΔ
metabuliThis PR may lead to different results in pre-existing outputs: Yes/No
This PR uses an element that could cause duplicate runs to have different results: Yes/No
🛠️ Changes
(may be too big)⚙️ Algorithm
➡️ Inputs
read_QC_trim_se +7 -4
theiaviral_ont +2 -1
theiaviral_illumina_pe +2 -0
theiaviral_panel +2 -0
read_QC_trim_pe +2 -0
metabuli_wf +46 -0
⬅️ Outputs
theiaviral_ont +1 -0
metabuli_wf +26 -0
🧪 Testing
fastp_pe, fastp_sefreyja_fastqmetabuli_wf
fastp_pe, fastp_se, metabuli, metabuli_wftheiacov_illumina_pe - fastp check; main run for comparison: no differences observed in spot check
fastp_petheiacov_illumina_se - fastp check; main run for comparison; no differences observed in spot check
fastp_se
fastp_petheiaeuk_illumina_pe
fastp_petheiameta_illumina_pe
fastp_petheiaprok_illumina_pe
fastp_setheiaprok_illumina_setheiaviral_illumina_pe - fastp check; main run for comparison; minor differences observed in spot check attributed to default parameters changing between versions
fastp_petheiaviral_ont
metabuli, theiaviral_ont
fastp_petheiaviral_panelSuggested Scenarios for Reviewer to Test
🔬 Final Developer Checklist
docs/assets/tables/all_workflows.tsvtable to be the tag for the next upcoming release. If you do not know the tag, please put "vX.X.X"🎯 Reviewer Checklist