Make MessageID accessible via Django backend#88
Closed
brendanwood wants to merge 2 commits intothemartorana:masterfrom
Closed
Make MessageID accessible via Django backend#88brendanwood wants to merge 2 commits intothemartorana:masterfrom
brendanwood wants to merge 2 commits intothemartorana:masterfrom
Conversation
…whether to return Postmark message IDs when available.
Collaborator
|
Seems like this would break on bulk message sending, as the PMBatchMail object doesn't have |
Author
|
Yeah that's true, I only looked at individual sends using the Django backend. |
Collaborator
|
Implemented this a bit safer with some tests in #89. Thank you for the example and the PR |
Author
|
Thank you, glad to hear it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's helpful to be able to log the MessageID for each email sent through the Postmark backend. This pull request introduces a new setting
POSTMARK_RETURN_MESSAGE_ID(default False) that instructs the Postmark backend to return the MessageID field from the API response whens sending email.This pull request is in reference to this open issue: #59
The code solution is based on this commit from andrebaptista's fork: andrebaptista@cc4e813