Skip to content

Let the bookmark support the CDN#106

Merged
wafer-li merged 1 commit intotheme-next:masterfrom
tsanie:cdn-support-bookmark
Feb 2, 2018
Merged

Let the bookmark support the CDN#106
wafer-li merged 1 commit intotheme-next:masterfrom
tsanie:cdn-support-bookmark

Conversation

@tsanie
Copy link
Contributor

@tsanie tsanie commented Feb 2, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): N/A

What is the new behavior?

There is no need to clone the bookmark repo into the source/lib, just set the CDN url instead.

  • Screens with this changes: N/A
  • Link to demo site with this changes: https://tsanie.us (removed the source/lib/bookmark directory)

How to use?

In NexT _config.yml:

vendors:
  ...
  # use a CDN instead of clone the whole third-party repo
  bookmark: https://cdn.jsdelivr.net/gh/theme-next/theme-next-bookmark@1.0.0/bookmark.min.js

Does this PR introduce a breaking change?

  • Yes.
  • No.

@wafer-li wafer-li merged commit 9353117 into theme-next:master Feb 2, 2018
@wafer-li wafer-li added this to the v6.0.4 milestone Feb 2, 2018
@tsanie tsanie deleted the cdn-support-bookmark branch February 2, 2018 06:10
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants