Fix several bugs reported in v7.3#1060
Merged
stevenjoezhang merged 5 commits intomasterfrom Aug 9, 2019
Merged
Conversation
Closed
ivan-nginx
reviewed
Aug 5, 2019
Member
ivan-nginx
left a comment
There was a problem hiding this comment.
May I ask why u remove active-menu selector from backend and add it to frontend? Just try to force refresh browser (CTRL+SHIFT+R) and see what happen: in your variant menu will be selected not instantly.
Contributor
Author
|
It's for PJAX and cache. Because menu items on every page is same, the only difference is the active one. So move the script to the front-end would be better. Otherwise PJAX have to refresh the whole menu... and the animation (velocity & motion) have to play again... it's too complicated |
Member
|
PJAX don't work with backend? |
Contributor
Author
|
PJAX will load the whole page, and replace the specified elements, e.g. sidebar |
Contributor
Author
ivan-nginx
approved these changes
Aug 9, 2019
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?