Skip to content

Add reading_progress to vendors#107

Merged
wafer-li merged 2 commits intotheme-next:masterfrom
maple3142:master
Feb 3, 2018
Merged

Add reading_progress to vendors#107
wafer-li merged 2 commits intotheme-next:masterfrom
maple3142:master

Conversation

@maple3142
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe: add field in _config.yml

What is the current behavior?

User doesn't know reading_progress can use cdn.

Issue Number(s): #105

What is the new behavior?

User knows reading_progress can use cdn.

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

vendors:
  # something....
  reading_progress: #cdn url

Does this PR introduce a breaking change?

  • Yes.
  • No.

Copy link
Member

@wafer-li wafer-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use min.js as the example.

_config.yml Outdated
# reading_progress
# Internal version: 1.0
# https://github.com/theme-next/theme-next-reading-progress
# Example: https://cdn.jsdelivr.net/gh/theme-next/theme-next-reading-progress@1.0/reading_progress.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use min.js as the example will be better I think.

@wafer-li wafer-li merged commit 9b8065a into theme-next:master Feb 3, 2018
@wafer-li wafer-li added this to the v6.0.4 milestone Feb 3, 2018
@stevenjoezhang stevenjoezhang changed the title add reading_progress to vendors Add reading_progress to vendors Sep 15, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants