Feature: related posts, according to #67 by tsanie · Pull Request #109 · theme-next/hexo-theme-next

tsanie · 2018-02-03T06:05:15Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Not an issue but according to the feature in roadmap.
By using the hexo-related-popular-posts that mentioned in the iissnan/hexo-theme-next#1130

Issue Number(s): #67

What is the new behavior?

When the user have enable the feature, the related posts will be shown in the bottom of the post.

Screens with this changes:
Link to demo site with this changes: https://tsanie.us/2018/01/07/replace-destiny-child-character-next/

How to use?

In NexT _config.yml:

# Related popular posts
# Dependencies: https://github.com/tea3/hexo-related-popular-posts
related_posts:
  enable: true
  title: # will be shown as the title
  params:
    # this is the plugin params
    maxCount: 5
    #ulClass: 'popular-posts'
    #PPMixingRate: 0.0
    #isDate: false
    #isImage: false
    #isExcerpt: false

Does this PR introduce a breaking change?

Yes.
No.

wafer-li · 2018-02-08T17:10:04Z

Pretty good!

But I wonder if it is the good practice to show the related posts right under the Read more?

Is it better to hide it inside the full post content or just show it?

wafer-li

Provide i18n for Related Posts field.

wafer-li · 2018-02-08T17:11:57Z

source/css/_common/components/third-party/related-posts.styl

+  padding: 0;
+
+  &:before {
+    content: hexo-config('related_posts.title') || 'Related Posts';


I think it is better to provide i18n for the Related Posts(ie. Related Posts -> 相关文章 in language zh-CN)

Yes, i think so too.

ivan-nginx · 2018-02-08T17:14:18Z

But I wonder if it is the good practice to show the related posts right under the Read more?

@tsanie there are similar issues:

Need to add switch option to show/hide on homepage (if is not home).
Support for Related Posts title with i18n directory.

…ated-posts

…home page, and add support to i18n.

tsanie

Add a switch related_posts.display_in_home to determine whether related posts will be shown in the home page.

And a language item post.related_posts, need to sync to crowdin and translate it.

Live demo updated: https://tsanie.us (the configure related_posts.display_in_home is setting to false, now it will be only shown in the post page)

ivan-nginx · 2018-02-09T03:52:10Z

source/css/_common/components/third-party/related-posts.styl

+    margin-left: 2em;
+    .popular-posts-title {
+      display: block;
+      h3 {


H3 here? And if will seo false and then main title will H1 and no headers will used — H1-H3 space?

@ivan-nginx It is generated by the plugin (https://github.com/theme-next/hexo-theme-next/pull/109/files#diff-0e030eb6dd7b9d25bfcba06bc8ea5609R337), otherwise, do we need to custom the template?

H3 in the bottom bad for SEO. For example, if SEO will true and we will have:

H1 (site_subtitle) H2 (title) H3 H4 H5 H3 H4 H3 (related_posts)

It's already fine with SEO. But if SEO false, then we can get fine result:

H1 (title) H2 H3 (related_posts)

But we also may get bad result:

H1 (title) ??? H3 (related_posts)

So, with SEO disabled & releated_posts enabled user can totally break his seo.

Headers can go forward only seriatim. And can go back with any new position (header reseting). They can't go forward bigger then 1 or more step (e.g. H4 header and after H6).

hexo-theme-next/source/css/_schemes/Gemini/index.styl

Lines 131 to 160 in 82ac7af

.post-body {

h1 {

font-size: 1.6em;

border-bottom: 1px solid $body-bg-color;

}

h2 {

font-size: 1.45em;

border-bottom: 1px solid $body-bg-color;

}

h3 {

font-size: 1.3em;

if use_seo {

border-bottom: 1px solid $body-bg-color;

} else {

border-bottom: 1px dotted $body-bg-color;

}

}

h4 {

font-size: 1.2em;

if use_seo {

border-bottom: 1px dotted $body-bg-color;

}

}

h5 {

font-size: 1.07em;

}

h6 {

font-size: 1.03em;

}

}

ivan-nginx · 2018-02-09T05:12:33Z

layout/_macro/post.swig

        {{ post.content }}
      {% endif  %}
    </div>
+


So many for now. oO Mb move to external swig file?
Like post-copyright.swig.

@ivan-nginx OK, seems now it need to be move to the single file.

tsanie · 2018-02-09T05:13:41Z

use the custom template to generate the output, removal the H3 tags

wafer-li

Everything is fine.

Except for the i18n translations, we could use the crowdin to fix it.

sli1989 · 2018-02-12T09:14:47Z

npm install hexo-related-popular-posts --save is needed?

tsanie · 2018-02-12T09:32:27Z

@sli1989 Of course, need to follow the dependencies described in the _config.yml

Feature: related posts, according to theme-next#67

tsanie added 3 commits February 3, 2018 13:53

initial related-posts

85d8f64

style adjust

7f992ee

set the default configure

b453402

wafer-li requested changes Feb 8, 2018

View reviewed changes

tsanie added 2 commits February 9, 2018 10:26

Merge remote-tracking branch 'remotes/remote/master' into feature-rel…

3e3d10a

…ated-posts

add a switch to determine whether related posts will be shown in the …

0645368

…home page, and add support to i18n.

tsanie commented Feb 9, 2018

View reviewed changes

ivan-nginx reviewed Feb 9, 2018

View reviewed changes

tsanie added 2 commits February 9, 2018 13:06

using the custom output template.

822696b

fix the default configure

8ddc9d4

ivan-nginx reviewed Feb 9, 2018

View reviewed changes

move the template to the single file.

3c44d16

wafer-li approved these changes Feb 9, 2018

View reviewed changes

tsanie merged commit e673805 into theme-next:master Feb 9, 2018

tsanie added this to the v6.0.4 milestone Feb 9, 2018

tsanie added the 🔌 3rd Party Plugin label Feb 9, 2018

ivan-nginx mentioned this pull request Feb 9, 2018

NexT v7.x Roadmap #67

Closed

72 tasks

tsanie deleted the feature-related-posts branch February 9, 2018 10:56

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019

Merge pull request theme-next#109 from tsanie/feature-related-posts

cc4290f

Feature: related posts, according to theme-next#67

	.post-body {
	h1 {
	font-size: 1.6em;
	border-bottom: 1px solid $body-bg-color;
	}
	h2 {
	font-size: 1.45em;
	border-bottom: 1px solid $body-bg-color;
	}
	h3 {
	font-size: 1.3em;
	if use_seo {
	border-bottom: 1px solid $body-bg-color;
	} else {
	border-bottom: 1px dotted $body-bg-color;
	}
	}
	h4 {
	font-size: 1.2em;
	if use_seo {
	border-bottom: 1px dotted $body-bg-color;
	}
	}
	h5 {
	font-size: 1.07em;
	}
	h6 {
	font-size: 1.03em;
	}
	}

Conversation

tsanie commented Feb 3, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

Uh oh!

wafer-li commented Feb 8, 2018

Uh oh!

wafer-li left a comment

Choose a reason for hiding this comment

Uh oh!

wafer-li Feb 8, 2018

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Feb 8, 2018

Choose a reason for hiding this comment

Uh oh!

ivan-nginx commented Feb 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsanie left a comment

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Feb 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsanie Feb 9, 2018

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Feb 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Feb 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsanie Feb 9, 2018

Choose a reason for hiding this comment

Uh oh!

tsanie commented Feb 9, 2018

Uh oh!

wafer-li left a comment

Choose a reason for hiding this comment

Uh oh!

sli1989 commented Feb 12, 2018

Uh oh!

tsanie commented Feb 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ivan-nginx commented Feb 8, 2018 •

edited

Loading

ivan-nginx Feb 9, 2018 •

edited

Loading

ivan-nginx Feb 9, 2018 •

edited

Loading

ivan-nginx Feb 9, 2018 •

edited

Loading