Fix fancybox & medium-zoom for hexo asset_img tag#1166
Merged
stevenjoezhang merged 2 commits intotheme-next:masterfrom Sep 19, 2019
sankoshine:fix-mediumzoom
Merged
Fix fancybox & medium-zoom for hexo asset_img tag#1166stevenjoezhang merged 2 commits intotheme-next:masterfrom sankoshine:fix-mediumzoom
stevenjoezhang merged 2 commits intotheme-next:masterfrom
sankoshine:fix-mediumzoom
Conversation
|
Thanks so much for opening your first PR here! |
Member
|
Can you test whether <img> under <a> label is also managed by mediumzoom ? Some users expect the link to work. |
Contributor
|
And you can also fix fancybox in this PR |
Contributor
Author
stevenjoezhang
suggested changes
Sep 17, 2019
Contributor
stevenjoezhang
left a comment
There was a problem hiding this comment.
In fact, in the stylesheet of theme-next, .post-body > p > img is different from .post-body > img (with a margin of 20px)
Thus a better solution is to ask Hexo to fix the bug of asset_image tag: <img> should always be wrapped with <p>.
Member
Member
stevenjoezhang
approved these changes
Sep 18, 2019
Contributor
stevenjoezhang
left a comment
There was a problem hiding this comment.
There seems to be no more elegant solution
|
Congrats on merging your first pull request here! 🎉 How awesome! |
Member
|
@all-contributors please add @sankoshine for bug |
Contributor
|
I've put up a pull request to add @sankoshine! 🎉 |
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
If I use hexo tag plugins to insert an image, it will not be rendered as medium zoom style.
i.e.
{% asset_img 2222.jpg %}What is the new behavior?
Medium zoom take effects on images whether imported with hexo
asset_imgtag or markdown-style.How to use?
Just set true.
In NexT
_config.yml:Does this PR introduce a breaking change?