Skip to content

Use .length instead of .size()#120

Merged
ivan-nginx merged 1 commit intotheme-next:masterfrom
Raincal:jquery-related
Feb 7, 2018
Merged

Use .length instead of .size()#120
ivan-nginx merged 1 commit intotheme-next:masterfrom
Raincal:jquery-related

Conversation

@Raincal
Copy link
Member

@Raincal Raincal commented Feb 7, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

After upgrade to jQuery 3.3.1
2018-02-07 04 07 27 pm
https://api.jquery.com/size/
The .size() method was deprecated in jQuery 1.8 and removed in 3.0, use .length instead

Issue Number(s): N/A

What is the new behavior?

The page renders correctly when upgrade to jQuery 3.3.1

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's!

@ivan-nginx ivan-nginx merged commit 266ad62 into theme-next:master Feb 7, 2018
@Raincal Raincal deleted the jquery-related branch February 7, 2018 12:17
@wafer-li wafer-li added this to the v6.0.4 milestone Feb 10, 2018
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants