Skip to content

fix(fancybox): add data-fancybox attribute for fancybox3#126

Merged
ivan-nginx merged 1 commit intotheme-next:masterfrom
Raincal:fancybox
Feb 8, 2018
Merged

fix(fancybox): add data-fancybox attribute for fancybox3#126
ivan-nginx merged 1 commit intotheme-next:masterfrom
Raincal:fancybox

Conversation

@Raincal
Copy link
Member

@Raincal Raincal commented Feb 8, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

2018-02-09 3 17 45

Issue Number(s): N/A

What is the new behavior?

Description about this pull, in several words...
2018-02-09 4 31 42

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx
Copy link
Member

@Raincal can u test this with fancybox2? All working fine?

@Raincal
Copy link
Member Author

Raincal commented Feb 8, 2018

It works fine with fancybox2

@ivan-nginx ivan-nginx added this to the v6.0.4 milestone Feb 8, 2018
@ivan-nginx ivan-nginx added Bug and removed Bug labels Feb 8, 2018
@ivan-nginx ivan-nginx merged commit 77d5d08 into theme-next:master Feb 8, 2018
@Raincal Raincal deleted the fancybox branch February 8, 2018 21:34
@chy9002
Copy link

chy9002 commented Mar 6, 2018

I try to add fancybox3 in my website, but there is a wired issue. Button icons aren't visible, is anybody know how to resolve it?
fb3_1

@gapplef gapplef mentioned this pull request May 16, 2018
11 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
fix(fancybox): add data-fancybox attribute for fancybox3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants