Skip to content

Improve accessibility #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-nginx merged 1 commit into from
Mar 14, 2018
Merged

Improve accessibility #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions languages/_en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,8 @@ reward:
bitcoin: Bitcoin

gitmentbutton: Show comments from Gitment

accessibility:
nav_toggle: Toggle navigation bar
prev_page: Previous page
next_page: Next page
2 changes: 1 addition & 1 deletion layout/_partials/head/head.swig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<meta charset="UTF-8"/>
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1"/>
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=2"/>
Copy link
Member

@ivan-nginx ivan-nginx Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not to do site larger by double click?

Copy link
Contributor Author

@maple3142 maple3142 Feb 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
here said shouldn't disable zoom

Copy link

@songouyang songouyang Jun 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in wechat, a zoom buttom in lower right corner appears. could it be optional in _config.yml? @maple3142
374975667

<meta name="theme-color" content="{{ theme.android_chrome_color }}">


Expand Down
2 changes: 1 addition & 1 deletion layout/_partials/header.swig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>

<div class="site-nav-toggle">
<button>
<button aria-label="{{ __('accessibility.nav_toggle') }}">
<span class="btn-bar"></span>
<span class="btn-bar"></span>
<span class="btn-bar"></span>
Expand Down
4 changes: 2 additions & 2 deletions layout/_partials/pagination.swig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<nav class="pagination">
{{
paginator({
prev_text: '<i class="fa fa-angle-left"></i>',
next_text: '<i class="fa fa-angle-right"></i>',
prev_text: '<i class="fa fa-angle-left" aria-label="'+__('accessibility.prev_page')+'"></i>',
next_text: '<i class="fa fa-angle-right" aria-label="'+__('accessibility.next_page')+'"></i>',
mid_size: 1
})
}}
Expand Down