Skip to content

Fix a syntax issue about IE compatible#139

Merged
tsanie merged 2 commits intotheme-next:masterfrom
tsanie:fix-valine-plugin-syntax
Feb 13, 2018
Merged

Fix a syntax issue about IE compatible#139
tsanie merged 2 commits intotheme-next:masterfrom
tsanie:fix-valine-plugin-syntax

Conversation

@tsanie
Copy link
Contributor

@tsanie tsanie commented Feb 13, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

IE doesn't support the Arrow Function, change it back to the anonymous function.

Issue Number(s): #138

What is the new behavior?

Valine comment will work right in the IE browser.

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

N/A

Does this PR introduce a breaking change?

  • Yes.
  • No.


# valine comment
# Example: https://cdn.jsdelivr.net/npm/valine@1.1.8/dist/Valine.min.js
valine:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional allow to custom the CDN for valine

@tsanie tsanie merged commit 9c0859b into theme-next:master Feb 13, 2018
@tsanie tsanie added this to the v6.0.5 milestone Feb 13, 2018
@tsanie tsanie deleted the fix-valine-plugin-syntax branch February 13, 2018 05:32
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
lkv1988 pushed a commit to lkv1988/hexo-theme-next that referenced this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants