Skip to content

Fix single quotes in lean-analytics.swig are not escaped#171

Merged
LEAFERx merged 5 commits intotheme-next:masterfrom
LEAFERx:master
Mar 15, 2018
Merged

Fix single quotes in lean-analytics.swig are not escaped#171
LEAFERx merged 5 commits intotheme-next:masterfrom
LEAFERx:master

Conversation

@LEAFERx
Copy link
Contributor

@LEAFERx LEAFERx commented Mar 15, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): #169

Does this PR introduce a breaking change?

  • Yes.
  • No.

@LEAFERx LEAFERx mentioned this pull request Mar 15, 2018
11 tasks
@ivan-nginx ivan-nginx added this to the v6.0.6 milestone Mar 15, 2018
@ivan-nginx ivan-nginx changed the title fix single quotes in lean-analytics.swig are not escaped Fix single quotes in lean-analytics.swig are not escaped Mar 15, 2018
@sli1989
Copy link
Collaborator

sli1989 commented Mar 15, 2018

It's better to added in theme's _config.yml.

@LEAFERx
Copy link
Contributor Author

LEAFERx commented Mar 15, 2018

@sli1989 ?

@sli1989
Copy link
Collaborator

sli1989 commented Mar 15, 2018

like this commit. I pulled the wrong branch, so close it.

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 15, 2018

@sli1989 affermative it. Need to add this description in NexT config, and i'm talking about it before, as i remember.

@LEAFERx
Copy link
Contributor Author

LEAFERx commented Mar 15, 2018

annotation added

@sli1989
Copy link
Collaborator

sli1989 commented Mar 15, 2018

Ask a digression, how to add commit in other's PR as a administrator? It seem no branch for a PR.

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 15, 2018

how to add commit in other's PR as a administrator

  1. Just edit files in «Files changed» tab (https://github.com/theme-next/hexo-theme-next/pull/171/files). But in this case u can't to edit new files, only files which shown in «Files changed» tab.
  2. Add pull as remote, checkout it and change what u want. Then push — will be pushed your commits in current pull directly. In this case u can edit any files from repo.

@sli1989
Copy link
Collaborator

sli1989 commented Mar 15, 2018

@ivan-nginx thanks.

@LEAFERx LEAFERx merged commit 580a8de into theme-next:master Mar 15, 2018
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Fix single quotes in lean-analytics.swig are not escaped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants