Skip to content

Fix css of copycode button#238

Merged
ivan-nginx merged 1 commit intotheme-next:masterfrom
maple3142:master
Apr 16, 2018
Merged

Fix css of copycode button#238
ivan-nginx merged 1 commit intotheme-next:masterfrom
maple3142:master

Conversation

@maple3142
Copy link
Contributor

@maple3142 maple3142 commented Apr 16, 2018

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Wrong button position after scrolling.
image

Issue Number(s): N/A

What is the new behavior?

Button will be fixed relative to parent.
image

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@maple3142
Copy link
Contributor Author

But I find this not working in IE11...
Is there any better way to achieve it?
Example fiddle

@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 16, 2018

I think IE11 not support anymore by most web things. Need to support at least Edge, if in Edge worked fine, it's alright.

See details in #30 issue.

@ivan-nginx ivan-nginx added this to the v6.2.0 milestone Apr 16, 2018
@ivan-nginx ivan-nginx merged commit 5cea4ef into theme-next:master Apr 16, 2018
@stevenjoezhang stevenjoezhang changed the title fix css of copycode button Fix css of copycode button Sep 15, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants