Skip to content

修复custom_logo.enable字段无用的BUG;给Gemini和Pisces添加custom_logo支持#274

Closed
chenghm123 wants to merge 5 commits intotheme-next:masterfrom
chenghm123:master
Closed

修复custom_logo.enable字段无用的BUG;给Gemini和Pisces添加custom_logo支持#274
chenghm123 wants to merge 5 commits intotheme-next:masterfrom
chenghm123:master

Conversation

@chenghm123
Copy link

1、修复custom_logo.enable字段无用的BUG
2、给Gemini和Pisces添加custom_logo支持

2、给Gemini和Pisces添加custom_logo支持
@LEAFERx LEAFERx requested a review from ivan-nginx May 6, 2018 04:07
Copy link
Contributor

@LEAFERx LEAFERx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change title and discription to English please.

2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems default settings was changed in _config.yml.
Please, fix it. And thank's for pull!

haiming.cheng added 2 commits May 6, 2018 22:53
2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
@chenghm123
Copy link
Author

chenghm123 commented May 6, 2018

Sorry! I'm first time pull.

2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
@sli1989
Copy link
Collaborator

sli1989 commented May 14, 2018

Can u re-modify the pr according to the new file where config.title to title, and the added section maybe added before the line12.

{% set title = __('title') !== 'title' && __('title') || config.title %}

@stevenjoezhang
Copy link
Contributor

Superseded by #520

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants