Skip to content

Fix firestore wrong variables issue#388

Merged
sli1989 merged 1 commit intotheme-next:masterfrom
EvilMouth:firestore-fix
Aug 21, 2018
Merged

Fix firestore wrong variables issue#388
sli1989 merged 1 commit intotheme-next:masterfrom
EvilMouth:firestore-fix

Conversation

@EvilMouth
Copy link
Contributor

@EvilMouth EvilMouth commented Aug 12, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

#387
Issue Number(s): #387

What is the new behavior?

Description about this pull, in several words...
Fixed firestore use wrong variables problem

How to use?

In NexT _config.yml:

firestore:
  enable: true

Does this PR introduce a breaking change?

  • Yes.
  • No.

@maple3142
Copy link
Contributor

Besides, I haven't used this plugin for a while because of the size of the external js files.(firebase & firestore)
As a result, what about deprecate this plugin? @ivan-nginx

@ivan-nginx
Copy link
Member

FireStore – Google tool.
LeanCloud – China tool.

I think no need deprecate geolocation tools because theme must be for all peoples in the world.

@sli1989 sli1989 added this to the v6.5.0 milestone Aug 16, 2018
@sli1989 sli1989 merged commit 79932de into theme-next:master Aug 21, 2018
@EvilMouth EvilMouth deleted the firestore-fix branch August 21, 2018 08:31
Jona-lee pushed a commit to Jona-lee/hexo-theme-next that referenced this pull request Oct 10, 2018
@stevenjoezhang stevenjoezhang changed the title Fixed firestore use wrong variables problem Fix firestore wrong variables issue Sep 15, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants