Fix disqus lazyload not working in Safari#406
Merged
ivan-nginx merged 2 commits intotheme-next:masterfrom Sep 14, 2018
Merged
Conversation
daya0576
changed the title
daya0576
force-pushed
the
fix/disqus_lazyload_in_safari
branch
from
aa0222e to
25f8a24
Compare
daya0576
changed the title
Contributor
Author
Member
|
Can u please show live demo with this bugfix? |
Contributor
Author
Sure, check this video for detail. |
Member
|
And other schemes like Gemini have same behaviour? |
Contributor
Author
Yes, the root reason: |
Member
|
Thanks! 👍 |
Jona-lee
pushed a commit
to Jona-lee/hexo-theme-next
that referenced
this pull request
Oct 10, 2018
* Fix document.documentElement.scrollTop always return 0 in safari * Style two comments
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
* Fix document.documentElement.scrollTop always return 0 in safari * Style two comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
document.documentElement.scrollTopalways return 0 in safari, so Disqus will never pop up.What is the new behavior?
scrollTopin realtime to avoid some error, e.g. images lazy-loading or manually resizing browser window.Does this PR introduce a breaking change?
p.s. PR from a back-end developer, not so familiar with front-end code. Feel free to give me some comments XD. Cheers.