Skip to content

Fix TOC displayed in Overview#408

Merged
sli1989 merged 1 commit intotheme-next:masterfrom
cxyfreedom:bug-fix
Sep 11, 2018
Merged

Fix TOC displayed in Overview#408
sli1989 merged 1 commit intotheme-next:masterfrom
cxyfreedom:bug-fix

Conversation

@cxyfreedom
Copy link
Contributor

@cxyfreedom cxyfreedom commented Sep 11, 2018

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

TOC displayed in Overview if Overview was selected when open sidebar

  1. If you open automatically sidebar with post,TOC display correctly.
  2. clicking the overview, and close the sidebar.
  3. open the sidebar, the TOC will display in overview.

What is the new behavior?

Description about this pull, in several words...

TOC does not display in Overview if Overview was selected when open sidebar

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx ivan-nginx requested a review from sli1989 September 11, 2018 07:45
@sli1989
Copy link
Collaborator

sli1989 commented Sep 11, 2018

what do u mean? can u provide some screenshots?
u mean the toc displayed when clicking overview in sidebar? I can't reproduce this bug.

@cxyfreedom
Copy link
Contributor Author

cxyfreedom commented Sep 11, 2018

@sli1989
If you open automatically sidebar with post,TOC display correctly.
Then close sidebar and reopen sidebar, TOC will display in overview.

@sli1989
Copy link
Collaborator

sli1989 commented Sep 11, 2018

OK, I got u point, but I still can't reproduce this bug.


well, found. thanks.

@sli1989 sli1989 merged commit f5be864 into theme-next:master Sep 11, 2018
@sli1989 sli1989 added this to the v6.5.0 milestone Sep 11, 2018
Jona-lee pushed a commit to Jona-lee/hexo-theme-next that referenced this pull request Oct 10, 2018
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
ZodiacWind pushed a commit to ZodiacWind/hexo-theme-next that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants