Fix #399 and #394 fancybox misuse#468
Merged
Raincal merged 2 commits intotheme-next:masterfrom Nov 7, 2018
stevenjoezhang:fancybox
Merged
Fix #399 and #394 fancybox misuse#468Raincal merged 2 commits intotheme-next:masterfrom stevenjoezhang:fancybox
Raincal merged 2 commits intotheme-next:masterfrom
stevenjoezhang:fancybox
Conversation
Raincal
approved these changes
Nov 7, 2018
Closed
Ahaochan
added a commit
to Ahaochan/Ahaochan.github.io
that referenced
this pull request
Nov 8, 2018
Contributor
Author
|
@ivan-nginx In |
Ahaochan
added a commit
to Ahaochan/Ahaochan.github.io
that referenced
this pull request
Mar 16, 2019
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When you click the image, fancybox will load, then report an error because
https://github.comis not an image.Issue Number(s): #399 and #394
What is the new behavior?
Prevent the img in an anchor from being wrapped as fancybox.
When you click the image,
https://github.comwill open in a new tab.How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?