Menu external url by jiangtj · Pull Request #476 · theme-next/hexo-theme-next

jiangtj · 2018-11-13T04:57:39Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Menu didn't support jump to external links

Issue Number(s): N/A

What is the new behavior?

Menu support jump to external links

click google jump to www.google.com

Config in the end of this file
Previews:

Muse https://jiangtj.gitlab.io/next-test/muse
Mist https://jiangtj.gitlab.io/next-test/mist
Pisces https://jiangtj.gitlab.io/next-test/pisces
Gemini https://jiangtj.gitlab.io/next-test/gemini

How to use?

In NexT _config.yml:

  menu:
    home: / || home
    archives: /archives/ || archive
    google: https://www.google.com || google
    more:
      default: /more/ || info
      google: http://www.google.com || google
      more:
        google: https://www.google.com || google
        default: /more/ || info

Note
default is not supported, due to default is used for displaying some submenu info.

Does this PR introduce a breaking change?

Yes.
No.

sli1989 · 2018-11-29T08:21:20Z

layout/_partials/header/sub-menu.swig

@@ -21,7 +21,11 @@
              {% if itemName == 'default' %}
                {% set parentValue = subvalue.split('||')[0] | trim %}
              {% else %}


there is a problem with submenu
can u check this WITH Getting Started? https://test.saili.science/docs/

menu: home: / || home #about: /about/ || user categories: /categories/ || th archives: /archives/ || archive tags: /tags/ || tags #schedule: /schedule/ || calendar #sitemap: /sitemap.xml || sitemap #commonweal: /404/ || heartbeat #navi: /navi/ || paper-plane-o #hits: /hits/ || fire #comments: /comments/ || comment-o Docs: default: /docs/ || book Getting Started: default: https://github.com/theme-next/hexo-theme-next || flag

jiangtj · 2018-11-29T10:29:24Z

Yes, it didn't work on default.
But I think that default is used for display some submenu info, it shouldn't start with https://.
If you want Getting Started as a link to outside site, can write directly.

  Docs:
    default: /docs/ || book
    Getting Started: https://github.com/theme-next/hexo-theme-next || flag

sli1989 · 2018-11-29T10:33:33Z

well, i understand.
it's better to add explanatory note about this.

jiangtj · 2018-11-29T12:04:57Z

😂 I don't know where to add explanatory note, because there's no note about submenu.

ivan-nginx · 2018-11-29T12:06:56Z

@jiangtj just add here in this PR something like readme. Later it will be on main site.

jiangtj · 2018-11-29T12:42:11Z

@ivan-nginx okay，I updated this PR, Add note in How to use

ivan-nginx · 2018-12-10T11:17:24Z

@jiangtj maybe #463 PR (v6.6.0) already solved this problem. Please, check it.

jiangtj · 2018-12-10T11:30:08Z

@ivan-nginx this PR didn't solve it.

ivan-nginx · 2018-12-10T11:33:09Z

@jiangtj can you give some explanation on it, what currently didn't work? Because on your test site «Google» links work fine.

jiangtj · 2018-12-10T11:37:39Z

@ivan-nginx
In my test site, deploy two-branch, it merge menu-external-url and fix-same-submenu
Current Behavior:

jiangtj · 2018-12-10T11:44:18Z

This json is generated in deploy. It show deploy repo and branch info
https://jiangtj.gitlab.io/next-test/deploy.json

ivan-nginx · 2018-12-10T11:48:55Z

Ok, i check and confirm it. But i remember what in #463 PR i tested «Google» (external) links and they working fine.

Maybe Fix #495, #473 and #231 url_for() misuse #496 PR make this bug?
On your site you use latest master branch or latest release (v.6.6.0) version?

jiangtj · 2018-12-10T11:56:01Z

@ivan-nginx

You may only test outermost menu

ivan-nginx · 2018-12-10T12:15:56Z

So, the only problem for this PR:

Main menu work with «Google» links.
Submenu and sub-submenu not work with «Google» links?

jiangtj · 2018-12-10T13:03:22Z

Emmm... For main menu, generated link is https:/www.google.com, it lost / and it isn't correct link.
But on most browser, work 'fine'...

ivan-nginx · 2018-12-10T14:35:08Z

@jiangtj thanks for bugfixes for NexT!

* Add menu ext url support * Add doc * Simplified protocol condotion & Added exturl style in for Pisces/Gemini. * Added `.exturl` condition to span tag.

Brannua · 2022-05-08T04:04:03Z

Hi, may i ask a question ? I'm using the latest version of Next.

My site URL is xxx.com, and i want to set xxx.com/sub as a external_link.

However, because of the domain is not changed, so the xxx.com/sub is not open in a new tab.

If there is way to open xxx.com/sub in a new tab when i click it in menu ?

Brannua · 2022-05-08T04:06:40Z

@ivan-nginx Is there any solutions ? thanks very much.

Co-authored-by: Renovate Bot <bot@renovateapp.com>

jiangtj added 2 commits November 13, 2018 12:04

Add menu ext url support

809137a

Add doc

514fdb1

ivan-nginx added Need Confirm labels Nov 15, 2018

sli1989 added ⭐ Feature and removed Need Confirm labels Nov 29, 2018

sli1989 modified the milestone: v6.6.0 Nov 29, 2018

sli1989 requested changes Nov 29, 2018

View reviewed changes

ivan-nginx added 📖 Docs Need Review labels Nov 29, 2018

Merge branch 'master' into menu-external-url

1490eb1

ivan-nginx added the Wait for Answer label Dec 10, 2018

ivan-nginx added 🐞 Bug Fix ☑ Verified labels Dec 10, 2018

ivan-nginx removed Need Review labels Dec 10, 2018

ivan-nginx added 2 commits December 10, 2018 15:27

Simplified protocol condotion & Added exturl style in for Pisces/Gemini.

671fff5

Added .exturl condition to span tag.

7a17978

ivan-nginx added this to the v6.7.0 milestone Dec 10, 2018

ivan-nginx merged commit 87f515c into theme-next:master Dec 10, 2018

ivan-nginx removed the ⭐ Feature label Dec 10, 2018

jiangtj deleted the menu-external-url branch December 10, 2018 16:05

stevenjoezhang mentioned this pull request Mar 9, 2019

设置menu在新页面打开链接 iissnan/hexo-theme-next#846

Closed

wens07 pushed a commit to wens07/hexo-theme-next that referenced this pull request May 8, 2023

Update actions/checkout action to v3 (theme-next#476)

dc7cb39

Co-authored-by: Renovate Bot <bot@renovateapp.com>

Conversation

jiangtj commented Nov 13, 2018 • edited by ivan-nginx Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

Uh oh!

sli1989 Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

jiangtj commented Nov 29, 2018

Uh oh!

sli1989 commented Nov 29, 2018

Uh oh!

jiangtj commented Nov 29, 2018

Uh oh!

ivan-nginx commented Nov 29, 2018

Uh oh!

jiangtj commented Nov 29, 2018

Uh oh!

ivan-nginx commented Dec 10, 2018

Uh oh!

jiangtj commented Dec 10, 2018

Uh oh!

ivan-nginx commented Dec 10, 2018

Uh oh!

jiangtj commented Dec 10, 2018

Uh oh!

jiangtj commented Dec 10, 2018

Uh oh!

ivan-nginx commented Dec 10, 2018

Uh oh!

jiangtj commented Dec 10, 2018

Uh oh!

ivan-nginx commented Dec 10, 2018

Uh oh!

jiangtj commented Dec 10, 2018

Uh oh!

ivan-nginx commented Dec 10, 2018

Uh oh!

Brannua commented May 8, 2022

Uh oh!

Brannua commented May 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jiangtj commented Nov 13, 2018 •

edited by ivan-nginx

Loading