Fix submenu when path name is same#497
Merged
ivan-nginx merged 2 commits intotheme-next:masterfrom Dec 10, 2018
Merged
Conversation
Member
|
Please, test it with this configuration: menu:
News: / || info-circle
Docs:
default: /docs/ || book
Getting Started: /getting-started/ || flag
Theme Settings: /theme-settings/ || star
Third Party Services:
default: /third-party-services/ || plug
Algolia Search: /algolia-search/ || adn
Tag Plugins: /tag-plugins/ || rocket
Advanced Settings: /advanced-settings/ || rocket
FAQ's: /faqs/ || life-ring
Platforms: /platforms/ || retweet |
Member
Author
|
@ivan-nginx |
Member
|
@jiangtj here is bug founded: go to BTW, breadcrumbs file generated here: hexo-theme-next/layout/_partials/breadcrumb.swig Lines 1 to 23 in 87f515c |
Member
Author
Member
|
Here it's description for subdirectory: https://github.com/hexojs/hexo-starter/blob/f04af381af085de6d3f19518efa433c585791688/_config.yml#L14-L17 And, yes, without subdirectory it's worked (on localhost). |
Member
Author
|
@ivan-nginx Okay! Fixed. |
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
fix submenu when path name is same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When submenu path name is same, submenu2 is rendered twice


Issue Number(s): N/A
What is the new behavior?
Does this PR introduce a breaking change?