Fix inline code font-size mismatch within headers#514
Fix inline code font-size mismatch within headers#514stevenjoezhang merged 6 commits intotheme-next:masterfrom
Conversation
|
The Would you like to fix it? |
…y line to match coding style
|
@stevenjoezhang Thanks for pointing it out. I updated the PR to make sure Gemini header code uses the same font-size as header. It seems that Gemini is the only scheme that overrides the post font-size in _common/scaffolding/base.styl. Do you think it deserves a note in the comment in _common/scaffolding/base.styl? |
ivan-nginx
left a comment
There was a problem hiding this comment.
Do you think it deserves a note in the comment
I think it's deserves refactoring of Gemini scheme. No note.
|
Does this need manual merge? |
| font-size: 1.6em; | ||
| border-bottom: 1px solid $body-bg-color; | ||
| code { | ||
| font-size: 1em; |
There was a problem hiding this comment.
Mb need to define same em size?
For all headers below too.
There was a problem hiding this comment.
em | Relative to the font-size of the element (2em means 2 times the size of the current font) source
When setting h1 code font-size, the current font-size is already set to h1's font-size. Therefore, h1 code font-size 1em means relatively the same size as h1's font-size.
Here is my test results using Gemini theme with my fix. First image is the result using 1em. Second image is the result using 1.6em( the same font-size as h1).


* Fix inline code font-size mismatch within headers * Fix the mismatch in Gemini scheme font-size override, and remove empty line to match coding style
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Any inline code within headers will have mismatched font-size. The inline code will have the same font-size as fenced code, whereas it should have adjusted to whatever font-size the header has.

Issue Number(s): N/A
What is the new behavior?
The inline code should have adjusted to whatever font-size the header has.

How to use?
N/A
Does this PR introduce a breaking change?