Format code & update CDN URLs & fix #269 (copy_tex for KaTeX)#543
Format code & update CDN URLs & fix #269 (copy_tex for KaTeX)#543stevenjoezhang merged 3 commits intotheme-next:masterfrom stevenjoezhang:master
Conversation
_config.yml
Outdated
| # See: https://faisalman.github.io/ua-parser-js | ||
| # Example: | ||
| # ua_parser: //cdn.jsdelivr.net/npm/ua-parser-js@0.7.17/src/ua-parser.min.js | ||
| # ua_parser: //cdn.jsdelivr.net/npm/ua-parser-js@0.7.9/src/ua-parser.min.js |
There was a problem hiding this comment.
The latest version is 0.7.19
Is it possible to use the latest version?
There was a problem hiding this comment.
I found this in _config.yml:
# Be aware that you should use the same version as internal ones to avoid potential problems.
So I'm not sure if we need to update the internal version, in /source/lib/ua-parser-js/dist ?
There was a problem hiding this comment.
Dude, just enought to use:
//cdn.jsdelivr.net/npm/ua-parser-js@0/src/ua-parser.min.js – will be opened latest major version of any plugin (e.g. 0.7.19). It's info from jsdelivr.com, try to check it.
There was a problem hiding this comment.
Thanks, I have updated all links from cdn.jsdelivr.net in this way. Does anything else need to be done?
There was a problem hiding this comment.
Recheck it. Must be @x version. See my previous comment carefully.
There was a problem hiding this comment.
It said omit the version completely to get the latest one in jsdelivr.com ... so do you think it's necessary to add a @x after the package name?
There was a problem hiding this comment.
Yes, i tested it. Some libs not work without @x version. And in addition: major versions can broke all work, instead of minor versions.
There was a problem hiding this comment.
Then, in summary, if the internal version is 0.7.9, the latest version is 0.7.19, which one would you prefer?
cdn.jsdelivr.net/npm/ua-parser-js/src/ua-parser.min.js
cdn.jsdelivr.net/npm/ua-parser-js@0/src/ua-parser.min.js
cdn.jsdelivr.net/npm/ua-parser-js@0.7.9/src/ua-parser.min.js
cdn.jsdelivr.net/npm/ua-parser-js@0.7.19/src/ua-parser.min.js
There was a problem hiding this comment.
cdn.jsdelivr.net/npm/ua-parser-js@0/src/ua-parser.min.js
stevenjoezhang
changed the title
stevenjoezhang
changed the title
3 participants
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): N/A
What is the new behavior?
Description about this pull, in several words...
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?