Fix #48 Footer position by stevenjoezhang · Pull Request #550 · theme-next/hexo-theme-next

stevenjoezhang · 2018-12-30T16:28:36Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number(s): #48

https://galaxymimi.com/before/mist/
https://galaxymimi.com/before/muse/
https://galaxymimi.com/before/pisces/
https://galaxymimi.com/before/gemini/

What is the new behavior?

Description about this pull, in several words...

https://galaxymimi.com/after/mist/
https://galaxymimi.com/after/muse/
https://galaxymimi.com/after/pisces/
https://galaxymimi.com/after/gemini/

Screens with this changes:

Before & After
Muse:

Mist:

Pisces:

Gemini:

Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

Yes.
No.

ivan-nginx · 2018-12-30T17:20:14Z

Screens, please.

ivan-nginx · 2018-12-30T17:20:35Z

source/js/src/utils.js

  },

  getContentVisibilityHeight: function() {
-    var docHeight = $('#content').height();


For what needed this changes?

$('#content').height() doesn't contain the height of #comments, and it will lead to a wrong calculation of the page's height

So, go see examples with getContentVisibilityHeight function. Because i remember, it was work fine (but mb not with all comments systems) and mb not now.

You're right. I have thought about it, and seems it would be better to change it back... maybe it's just designed like this

Actually, this function for rightly back2top percentage ratio. When comments systems exists, horizontal height changed dynamically when page will scrolled, so, b2t percent was counting not rightly.
This all i remember when add this function. For now some comment systems have dynamic loading (like lazy option for Disqus), so, i suggest to retest it in future.

Here is changes for this function & b2t:

iissnan/hexo-theme-next@4bd315d (PR #1574)

iissnan/hexo-theme-next@028fe60
and addition iissnan/hexo-theme-next@61086aa
(PR #1898)

So, you can review this.

$('#content').height() doesn't contain the height of #comments, and it will lead to a wrong calculation of the page's height

As we can see, b2t percent not contain comments div to counting to around wrong percentage ratio. And #content – meaning content of div > post-block, not content of comments block. That's why this function exists.

Yes, need to discuss $('#content').height() and $('.container').height() in the future

Here is 2 problems:

Comment system can be loaded with lazy (viewport height will more only when user scrolled down).

Comment system loaded from 3rd-party side. So, JS on our server don't know which height we need to count.

But you can try to play around with this. Maybe you got success decision and make this coll feature (or bugfux).

What about adding this to NexT v7.x Roadmap(#67)? I have reviewed the previous changes, but have no idea how to solve this...

You can add it, of course. Anyway, I think NexT have more important things to improvment.

P.S. From next year we will start to work for v7.x and all bugfixes / features will pushed there. We also will resume maintenance for v6.x, but will be pushed only bugfixes. I want to create gantt roadmap something like in nodejs (https://github.com/nodejs/Release). Need to think about it better in details, any suggestions are welcome. In ideal need any chat with you to talk about this.

stevenjoezhang · 2018-12-30T17:28:56Z

Screens, please.

Wait a minute

@ivan-nginx Screenshots added

ivan-nginx · 2018-12-30T18:14:56Z

Also, read carefully this and this PR's.

ivan-nginx

Also, need to test on all possible resolutions all 4 schemes.
Here is good service for this: http://www.responsinator.com (or you can do it with browser if you want)
Screens or links, if it's possible.

stevenjoezhang · 2018-12-31T03:02:09Z

ivan-nginx · 2018-12-31T03:29:50Z

Bug in Pisces / Gemini:

Before:

After:

On Tablet & Mobile versions seems all fine. 👍

stevenjoezhang · 2018-12-31T05:27:13Z

@ivan-nginx Fixed now
And the color of b2t icon seems wrong in Pisces & Gemini while setting b2t: false in sidebar

Fix to #552. Comment: #550 (comment)

ivan-nginx

Well done!

* Fix theme-next#48

stevenjoezhang added 2 commits December 30, 2018 22:15

Fix #481

e726387

Fix #48

cbdf848

ivan-nginx reviewed Dec 30, 2018

View reviewed changes

Merge branch 'master' into master

296d81a

.container -> #content

3540e79

ivan-nginx requested changes Dec 30, 2018

View reviewed changes

Merge branch 'master' into master

ee43d5e

stevenjoezhang added 2 commits December 31, 2018 11:56

Merge branch 'master' into master

5d086a5

Merge branch 'master' of https://github.com/GalaxyMimi/hexo-theme-next

de2760e

fix Pisces & Gemini sidebar

6ead5d3

stevenjoezhang added ⭐ Feature 🐞 Bug Fix labels Dec 31, 2018

ivan-nginx added a commit that referenced this pull request Dec 31, 2018

Fix b2t color for Pisces | Gemini when b2t: false false.

e303420

Fix to #552. Comment: #550 (comment)

ivan-nginx approved these changes Dec 31, 2018

View reviewed changes

ivan-nginx added this to the v6.7.0 milestone Dec 31, 2018

Merge branch 'master' into master

7b627a9

stevenjoezhang merged commit 8a2051e into theme-next:master Dec 31, 2018

ivan-nginx removed the ⭐ Feature label Dec 31, 2018

stevenjoezhang changed the title ~~Fix #48~~ Fix #48 Footer position Dec 31, 2018

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019

Fix theme-next#48 (theme-next#550)

8531dd1

* Fix theme-next#48

Conversation

stevenjoezhang commented Dec 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

Uh oh!

ivan-nginx commented Dec 30, 2018

Uh oh!

ivan-nginx Dec 30, 2018

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang Dec 30, 2018

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Dec 30, 2018

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang Dec 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Dec 30, 2018

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Dec 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Dec 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Dec 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang Dec 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Dec 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang commented Dec 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivan-nginx commented Dec 30, 2018

Uh oh!

ivan-nginx left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang commented Dec 31, 2018

Uh oh!

ivan-nginx commented Dec 31, 2018

Uh oh!

stevenjoezhang commented Dec 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivan-nginx left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stevenjoezhang commented Dec 30, 2018 •

edited

Loading

stevenjoezhang Dec 30, 2018 •

edited

Loading

ivan-nginx Dec 30, 2018 •

edited

Loading

ivan-nginx Dec 30, 2018 •

edited

Loading

ivan-nginx Dec 30, 2018 •

edited

Loading

stevenjoezhang Dec 31, 2018 •

edited

Loading

ivan-nginx Dec 31, 2018 •

edited

Loading

stevenjoezhang commented Dec 30, 2018 •

edited

Loading

ivan-nginx left a comment •

edited

Loading

stevenjoezhang commented Dec 31, 2018 •

edited

Loading