Optimize the style of busuanzi, tag cloud and read more button#561
Merged
ivan-nginx merged 4 commits intotheme-next:masterfrom Jan 3, 2019
PKUPI:master
Merged
Optimize the style of busuanzi, tag cloud and read more button#561ivan-nginx merged 4 commits intotheme-next:masterfrom PKUPI:master
read more button#561ivan-nginx merged 4 commits intotheme-next:masterfrom
PKUPI:master
Conversation
ivan-nginx
reviewed
Jan 3, 2019
| </span> | ||
| {% endif %} | ||
|
|
||
| {% if theme.busuanzi_count.total_visitors and theme.busuanzi_count.total_views %} |
Member
There was a problem hiding this comment.
Mb not need divider here? Because it's one plugin.
Contributor
Author
There was a problem hiding this comment.
Add an option for users to decide then ?
Contributor
Author
There was a problem hiding this comment.
The separator | is displayed in NexT v5.x . Related to theme-next/theme-next.org#7
Member
There was a problem hiding this comment.
I mean about internal | separator.
This is pretty:
This is not so nice:
Separator almost is a delimeter between different categories or plugins.
Member
There was a problem hiding this comment.
But, if you want this separator, need to add style like this:
There is space between and after item.
Contributor
Author
There was a problem hiding this comment.
Oh, it's added, I forget to update the screenshot.
It looks fine
stevenjoezhang
changed the title
read more button
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
* Update tag-cloud.styl * Update index.styl * Update busuanzi-counter.swig * Update third-party.styl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved N/A
What is the new behavior?
Description about this pull, in several words...
Modified source/css/_common/components/tag-cloud.styl
and source/css/_schemes/Gemini/index.styl
and layout/_third-party/analytics/busuanzi-counter.swig
and source/css/_common/components/third-party/third-party.styl
Also, source/css/_common/components/third-party/busuanzi-counter.styl can be removed.
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?