Skip to content

Optimize the loading of comment systems#566

Merged
stevenjoezhang merged 5 commits intotheme-next:masterfrom
GalaxyMimi:comment
Jan 5, 2019
Merged

Optimize the loading of comment systems#566
stevenjoezhang merged 5 commits intotheme-next:masterfrom
GalaxyMimi:comment

Conversation

@stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved iissnan/hexo-theme-next#1868

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve conflicts before merging.

@ivan-nginx ivan-nginx added this to the v7.0.0 milestone Jan 5, 2019
@ivan-nginx
Copy link
Member

Is it PR ready?

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jan 5, 2019

I'll check again to ensure that there are no potential problems

@stevenjoezhang
Copy link
Contributor Author

I think it's ready to be merged now

@stevenjoezhang stevenjoezhang merged commit 9273b0a into theme-next:master Jan 5, 2019
@stevenjoezhang stevenjoezhang deleted the comment branch January 5, 2019 08:31
ivan-nginx added a commit that referenced this pull request Jan 5, 2019
* Optimize valine and gitment comment
* Update disqus.swig
anthqiu pushed a commit to anthqiu/hexo-theme-next that referenced this pull request Aug 1, 2019
# By Mimi (4) and others
# Via Ivan.Nginx
* 'v6.x' of git@github.com:AntSYau/hexo-theme-next.git:
  add: details of configuration (theme-next#588)
  bugfix: make request time of leancloud saved and let concurrent requests pass (theme-next#519)
  Reorganize theme-next#576, using macro (theme-next#582)
  Edit Google Analytics reference file address (theme-next#580)
  Fix theme-next#573: [Muse & Mist] Footer is not at the bottom of the page (theme-next#574)
  Update Gitment URL to use jsDelivr CDN (theme-next#572)
  Fix theme-next#569 Valine Comment Count (theme-next#570)
  Improve styles of Gitalk & Gitment  (theme-next#568)
  Optimize the loading of comment systems (theme-next#566)

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md
#	_config.yml
#	layout/_macro/post.swig
#	layout/_partials/comments.swig
#	layout/_partials/github-banner.swig
#	layout/_scripts/schemes/muse.swig
#	layout/_third-party/analytics/google-analytics.swig
#	layout/_third-party/comments/disqus.swig
#	layout/_third-party/comments/gitalk.swig
#	layout/_third-party/comments/gitment.swig
#	layout/_third-party/comments/index.swig
#	layout/_third-party/comments/valine.swig
#	layout/_third-party/copy-code.swig
#	source/css/_common/components/header/github-banner.styl
#	source/css/_common/components/pages/schedule.styl
#	source/css/_common/components/post/post-reward.styl
#	source/css/_common/components/sidebar/sidebar.styl
#	source/css/_common/components/tags/note-modern.styl
#	source/css/_common/scaffolding/tables.styl

Signed-off-by: Anthony Yau <antsyau@outlook.com>
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
* Optimize valine and gitment comment

* Update disqus.swig
wens07 pushed a commit to wens07/hexo-theme-next that referenced this pull request May 8, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

页面设置关闭评论后报错

2 participants