Fancybox for group-picture and post-gallery by stevenjoezhang · Pull Request #667 · theme-next/hexo-theme-next

stevenjoezhang · 2019-03-09T01:06:28Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes was maked (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue resolved: #296
See: iissnan/hexo-theme-next@6077877

What is the new behavior?

Screenshots with this changes: N/A
Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

Yes.
No.

Update

1v9 · 2019-03-09T05:58:30Z

screenshot? never use this feature...😂

stevenjoezhang · 2019-03-09T09:30:25Z

@1v9 See: #296

1v9 · 2019-03-09T09:45:58Z

@stevenjoezhang I tested group pictures, it's fancybox now, good job.

stevenjoezhang · 2019-03-09T09:57:04Z

You can also try this:

---
title: title
date: 2019-03-09 17:52:00
photos:
  - https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d
  - https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d
  - https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d
  - https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d
  - https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d
---

{% gp 5-2 %}
![](https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d)
![](https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d)
![](https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d)
![](https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d)
![](https://marketplace-images.githubusercontent.com/2388/1c118380-1ff1-11e9-89b2-1402fd4f7f2d)
{% endgp %}

ivan-nginx

GJ!

ivan-nginx · 2019-03-09T10:18:15Z

layout/_macro/post.swig

            {% if loop.index0 % COLUMN_NUMBER === 0 %}<div class="post-gallery-row">{% endif %}
-              <a class="post-gallery-img fancybox"
-                 href="{{ url_for(photo) }}" rel="gallery_{{ post._id }}"
-                 itemscope itemtype="http://schema.org/ImageObject" itemprop="url">


But why u remove http://schema.org/ImageObject here?

This attribute belongs to the <a> tag which causes the bug, and that's why I removed it. I'll try to add it back, and test if fancybox still works fine.

stevenjoezhang · 2019-03-09T12:44:43Z

I make some other big changes to fit both fancybox 2 and 3, you can check again

stevenjoezhang · 2019-03-09T14:16:41Z

@maple3142 What happened?

1v9 · 2019-03-09T14:53:57Z

@stevenjoezhang answer is here 😂

stevenjoezhang · 2019-03-09T15:55:36Z

@1v9 Is it a mistake?

1v9 · 2019-03-09T15:57:30Z

@stevenjoezhang yeah i think so. merge upstream -> push to NexT?

stevenjoezhang · 2019-03-09T16:05:11Z

Done

maple3142 · 2019-03-09T16:07:57Z

Sorry, I clone NexT theme from this repo to my site.
And I accidentally pushed it(theme-next/hexo-theme-next) instead of main repo(Blog) after I update it from upstream.

1v9 · 2019-03-09T16:12:52Z

@stevenjoezhang 👍
@maple3142 so dangerous😂

ivan-nginx

Check images on https://validator.w3.org ?

ivan-nginx · 2019-03-16T07:20:54Z

layout/_macro/post.swig

-                 itemscope itemtype="http://schema.org/ImageObject" itemprop="url">
-                <img src="{{ url_for(photo) }}" itemprop="contentUrl"/>
-              </a>
+              <img src="{{ url_for(photo) }}" itemprop="contentUrl"/>


Maybe we must add itemscope itemtype="http://schema.org/ImageObject" here, before itemprop="contentUrl"? It's for schema.

stevenjoezhang · 2019-03-16T07:45:50Z

source/js/src/utils.js

-          $imageWrapLink.addClass('fancybox fancybox.image');
-          $imageWrapLink.attr('rel', 'group');
+          var imageLink = $image.attr('data-original') || $image.attr('src');
+          $imageWrapLink = $image.wrap('<a class="fancybox fancybox.image" href="' + imageLink + '" itemscope itemtype="http://schema.org/ImageObject" itemprop="url"></a>').parent('a');


@ivan-nginx Maybe the answer is no? See here.

Oh, ok ok. So long line there...

stevenjoezhang added 3 commits March 7, 2019 11:43

Merge pull request #1 from theme-next/master

c085223

Update

Merge pull request #2 from theme-next/master

1f82801

Merge pull request #3 from theme-next/master

424265c

stevenjoezhang added the ⭐ Feature label Mar 9, 2019

stevenjoezhang requested review from 1v9, ivan-nginx, jiangtj and maple3142 March 9, 2019 01:06

stevenjoezhang mentioned this pull request Mar 9, 2019

多图功能图片不能放大 iissnan/hexo-theme-next#1043

Closed

ivan-nginx approved these changes Mar 9, 2019

View reviewed changes

ivan-nginx reviewed Mar 9, 2019

View reviewed changes

1v9 approved these changes Mar 9, 2019

View reviewed changes

Fix #296

151fe1d

theme-next deleted a comment Mar 9, 2019

maple3142 approved these changes Mar 9, 2019

View reviewed changes

stevenjoezhang added this to the v7.1.0 milestone Mar 9, 2019

stevenjoezhang merged commit 48b1b60 into theme-next:master Mar 9, 2019

stevenjoezhang deleted the fancybox branch March 9, 2019 16:12

stevenjoezhang mentioned this pull request Mar 9, 2019

Problem with fancybox #296

Closed

11 tasks

stevenjoezhang mentioned this pull request Mar 12, 2019

Update to fancyBox 3.2.0 iissnan/hexo-theme-next#1989

Closed

15 tasks

ivan-nginx reviewed Mar 16, 2019

View reviewed changes

ivan-nginx added the Need Verify label Mar 16, 2019

stevenjoezhang commented Mar 16, 2019

View reviewed changes

ivan-nginx removed the Need Verify label Mar 16, 2019

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019

Fancybox for group-picture and post-gallery (theme-next#667)

025f4d3

Conversation

stevenjoezhang commented Mar 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

Uh oh!

1v9 commented Mar 9, 2019

Uh oh!

stevenjoezhang commented Mar 9, 2019

Uh oh!

1v9 commented Mar 9, 2019

Uh oh!

stevenjoezhang commented Mar 9, 2019

Uh oh!

ivan-nginx left a comment

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Mar 9, 2019

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang Mar 9, 2019

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang commented Mar 9, 2019

Uh oh!

stevenjoezhang commented Mar 9, 2019

Uh oh!

1v9 commented Mar 9, 2019

Uh oh!

stevenjoezhang commented Mar 9, 2019

Uh oh!

1v9 commented Mar 9, 2019

Uh oh!

stevenjoezhang commented Mar 9, 2019

Uh oh!

maple3142 commented Mar 9, 2019

Uh oh!

1v9 commented Mar 9, 2019

Uh oh!

ivan-nginx left a comment

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Mar 16, 2019

Choose a reason for hiding this comment

Uh oh!

stevenjoezhang Mar 16, 2019

Choose a reason for hiding this comment

Uh oh!

ivan-nginx Mar 16, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stevenjoezhang commented Mar 9, 2019 •

edited

Loading