Lost tracking_id in google_analytics#668
Merged
stevenjoezhang merged 1 commit intotheme-next:masterfrom Mar 9, 2019
sheiun:patch-1
Merged
Lost tracking_id in google_analytics#668stevenjoezhang merged 1 commit intotheme-next:masterfrom sheiun:patch-1
tracking_id in google_analytics#668stevenjoezhang merged 1 commit intotheme-next:masterfrom
sheiun:patch-1
Conversation
Fix lost tracking_id in google_analytics
stevenjoezhang
approved these changes
Mar 9, 2019
Contributor
|
Good job! |
tracking_id in google_analytics
tracking_id in google_analyticstracking_id in google_analytics
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
rjyblog
pushed a commit
to rjyblog/hexo-theme-next
that referenced
this pull request
Oct 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
google tag will load like this
//www.googletagmanager.com/gtag/js?id=[object%20Object]Issue resolved: N/A
What is the new behavior?
//www.googletagmanager.com/gtag/js?id=UA-XXXXXXX-XXXHow to use?
Change
google-analytics.swigfrom<script async src="//www.googletagmanager.com/gtag/js?id={{ theme.google_analytics }}"></script>to
<script async src="//www.googletagmanager.com/gtag/js?id={{ theme.google_analytics.tracking_id }}"></script>Does this PR introduce a breaking change?