Skip to content

Add english support for Valine comments#676

Merged
stevenjoezhang merged 4 commits intotheme-next:masterfrom
PKUPI:valine
Mar 11, 2019
Merged

Add english support for Valine comments#676
stevenjoezhang merged 4 commits intotheme-next:masterfrom
PKUPI:valine

Conversation

@stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 11, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Copy link
Member

1v9 commented Mar 11, 2019

Is 'zh-cn' default value?

@stevenjoezhang
Copy link
Contributor Author

Yes, only two available values😂

@stevenjoezhang stevenjoezhang merged commit 1c3e480 into theme-next:master Mar 11, 2019
@stevenjoezhang stevenjoezhang deleted the valine branch March 11, 2019 10:35
@ivan-nginx
Copy link
Member

@stevenjoezhang same question as above: why zh-cn by default if default language anywhere is en?

@1v9
Copy link
Member

1v9 commented Mar 16, 2019

@ivan-nginx
Copy link
Member

@1v9 I see. 2 build-in languages: en and cn. I don't understand why @stevenjoezhang set cn by default? Go ru language by default on creative_commons? Or for yandex_site_verification we will write comments above:

-# Yandex Webmaster tools verification setting
-# See: https://webmaster.yandex.ru
+# Настройки верификации Вебмастер-панели Яндекса
+# Смотрите: https://webmaster.yandex.ru

It is unacceptable.

Even Hexo have en language by default. Everywhere en language by default.
This. Is. International. Language.

@stevenjoezhang
Copy link
Contributor Author

@ivan-nginx The reason is that leancloud, one of the major dependencies of valine, doesn't provide English webpage nor documentation. I believe most users of leancloud or valine are not English speakers. See: https://medium.com/leancloud/getting-leancloud-ready-for-the-english-speaking-audience-97793bb413f1

And it's not hard to make English default language, just need to modify layout/_third-party/comments/valine.swig

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 16, 2019

I suggest 2 way-outs:

  1. lang: '{{ theme.valine.language }}' || 'zh-cn' → 'en'
  2. As we can see here — screenshoots on cn lang, LC on cn too. So, then need to write title something like that: Valine (China) and drop down this comment after all multilingual comments.

Here is example, BTW: https://theme-next.org/docs/third-party-services/statistics-and-analytics/

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 18, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants