Make CSS simpler using macro#738
Make CSS simpler using macro#738stevenjoezhang merged 6 commits intotheme-next:masterfrom stevenjoezhang:css
Conversation
| .post-eof, | ||
| .post-spread { | ||
| hide(); | ||
| display: none !important; |
There was a problem hiding this comment.
Need to recheck here, because values in base without !imortant.
hexo-theme-next/source/css/_mixins/base.styl
Lines 71 to 77 in 9876b88
There was a problem hiding this comment.
Yes, I have tested, this is an exception. All other ‘display: none’ style can be replaced with macro ‘none()’
There was a problem hiding this comment.
So, need to fix it somehow.
There was a problem hiding this comment.
No better solution, I think.
Or we can remove show, hide and circle macros. Currently, they are only used a few times.
There was a problem hiding this comment.
So, need any solution. For now you suggest Improvment (Optimization), but give 1 additional Bug with this.
Mb u can see why was !important there? And try to resolve this.
There was a problem hiding this comment.
display: none !important is used to overwrite the display: block style in .post-eof in scheme Gemini. To make sure it works on all browsers, an !important is needed. It won't cause additional bug.
There was a problem hiding this comment.
Remove show, hide and circle macros is another way. What's your opinion?
There was a problem hiding this comment.
display: none !importantis used to overwrite thedisplay: blockstyle in.post-eofin scheme Gemini. To make sure it works on all browsers, an!importantis needed. It won't cause additional bug.
I know it, why u say me what I already know? Question is: why there are used !important? What rewrited? Why only for Gemini? How to make without rewriting (without !important)? Is it possible? If possible, need to try it, yeah?
There was a problem hiding this comment.
Oh, I understand. I'll open another PR to reduce the usage of !important.
|
About |
|
Of course use macro |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?