Skip to content

New utteranc comments system#764

Closed
TrumanDu wants to merge 1 commit intotheme-next:masterfrom
TrumanDu:master
Closed

New utteranc comments system#764
TrumanDu wants to merge 1 commit intotheme-next:masterfrom
TrumanDu:master

Conversation

@TrumanDu
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
  • Muse | Mist have been tested.
  • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A
Should notice user about the permission of gitment

What is the new behavior?

add new comments

  • Screenshots with this changes: N/A
    QQ截图20190330235029

  • Link to demo site with this changes: N/A
    demo

How to use?

In NexT _config.yml:

# utteranc
# Demo: https://utteranc.es/  http://trumandu.github.io/about/
# theme: github-light,github-dark,github-dark-orange
utteranc:
  enable: true
  repo:  TrumanDu/comments
  pathname:  pathname
  theme: github-light

Does this PR introduce a breaking change?

  • Yes.
  • No.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2019

CLA assistant check
All committers have signed the CLA.

@LEAFERx
Copy link
Contributor

LEAFERx commented Mar 30, 2019

WOW! Seems a little better than gitment.

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, wait for merge #711 pull because there are global refactoring with comments.

@TrumanDu
Copy link
Author

TrumanDu commented May 5, 2019

ready now?

@jiangtj
Copy link
Member

jiangtj commented May 9, 2019

@ivan-nginx @TrumanDu
There are some controversies about refactoring comments, which can take a long time, so we can validate and merge the PR first.

@ivan-nginx
Copy link
Member

@jiangtj after that merge u will reedit your PR? If yes, of course merge it.

@jiangtj
Copy link
Member

jiangtj commented May 16, 2019

@jiangtj after that merge u will reedit your PR? If yes, of course merge it.

Yesh, I will reedit my PR after this merge.


# utteranc
# Demo: https://utteranc.es/ http://trumandu.github.io/about/
# theme: github-light,github-dark,github-dark-orange
Copy link
Contributor

@stevenjoezhang stevenjoezhang May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrumanDu Add a space after the comma

# Utteranc
# Demo: https://utteranc.es/
utteranc:
  enable: false
  repo: # Repository name to store issues, e.g. username/comments
  pathname: # Pathname
  # Available values: github-light | github-dark | github-dark-orange | dark-blue | icy-dark | photon-dark
  theme: github-light

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for Docs...

@ivan-nginx ivan-nginx self-requested a review May 20, 2019 16:32
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrumanDu please, add docs to NexT website.

@TrumanDu
Copy link
Author

@ivan-nginx here

@1v9
Copy link
Member

1v9 commented May 25, 2019

@TrumanDu Take a look at requested changes from @stevenjoezhang and me, once done we can merge this PR.


# utteranc
# Demo: https://utteranc.es/ http://trumandu.github.io/about/
# theme: github-light,github-dark,github-dark-orange
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed three themes, common user maybe won't find it.
https://github.com/utterance/utterances/tree/master/src/stylesheets/themes

@1v9 1v9 requested a review from ivan-nginx May 25, 2019 14:07
utteranc:
enable: false
repo: #Github repo such as :TrumanDu/comments
pathname: pathname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use issue-term, pathname is one value of this option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you need to make a simple explanation for some option like this or leave an useful link.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u have got it.add document in here

@jiangtj
Copy link
Member

jiangtj commented Jul 24, 2019

wow, utterances maybe better than gitalk

@jiangtj
Copy link
Member

jiangtj commented Jul 24, 2019

Emmm, there are some problems when the scheme is Gemini.
image

@1v9
Copy link
Member

1v9 commented Jul 24, 2019

Emmm, there are some problems when the scheme is Gemini.
image

脱缰野马😂

@jiangtj
Copy link
Member

jiangtj commented Jul 24, 2019

Besides, you can also try to make it use as a NexT plugin. (need use latest next theme)

e.g, copy this utterance.js to your hexo scripts, it will work as you expected.

If you want to make a NexT plugin, here are some examples to refer to.
https://github.com/theme-next/awesome-next#next-plugins next-plugins sections.
And then, submit PR to awesome-next 😄

GitHub
Awesome NexT! Contribute to theme-next/awesome-next development by creating an account on GitHub.

@jiangtj
Copy link
Member

jiangtj commented Jul 29, 2019

Done in here. Thank you for your work. https://github.com/theme-next/hexo-next-utteranc

GitHub
Utteranc comment system for NexT. Contribute to theme-next/hexo-next-utteranc development by creating an account on GitHub.

@jiangtj jiangtj closed this Jul 29, 2019
@jiangtj
Copy link
Member

jiangtj commented Sep 25, 2019

@all-contributors please add @TrumanDu for code

@allcontributors
Copy link
Contributor

@jiangtj

I've put up a pull request to add @TrumanDu! 🎉

stevenjoezhang referenced this pull request in next-theme/hexo-theme-next Nov 28, 2020
whyliam pushed a commit to whyliam/hexo-theme-next that referenced this pull request Apr 19, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants