Force include source/lib/font-awesome/#832
Merged
stevenjoezhang merged 1 commit intotheme-next:masterfrom Jun 9, 2019
zombie110year:master
Merged
Force include source/lib/font-awesome/#832stevenjoezhang merged 1 commit intotheme-next:masterfrom zombie110year:master
stevenjoezhang merged 1 commit intotheme-next:masterfrom
zombie110year:master
Conversation
|
Thanks so much for opening your first PR here! |
ivan-nginx
approved these changes
Apr 13, 2019
Member
|
Seems it's okey, now please sign CLA and we will merge it. All checks must be passed. |
Contributor
|
Seems this issue: #413 has been resolved? |
Contributor
Author
Yes, the issue described about what this PR solved. But there isn't I did't build this repo in local machine and almost know nothing about nodejs, so I don't now whether the directory will be generated by developing tools. Should add other exclude rule in it? |
stevenjoezhang
approved these changes
Apr 29, 2019
Member
|
@stevenjoezhang pull verified by you? |
1v9
approved these changes
Jun 8, 2019
Contributor
|
@ivan-nginx Verified. |
|
Congrats on merging your first pull request here! 🎉 How awesome! |
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
.gitignoreWhat is the current behavior?
The origin version was
!source/lib/font-awesome/*, but it doesn't work. While I published my blog through Travis CI, It didn't include the font-awersome lib. And my Git GUI told that the dir was excluded by .gitignore.Issue resolved: #413
What is the new behavior?
Now it works.
Does this PR introduce a breaking change?