Skip to content

Improve page rendering by deferring disqus loading #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1v9 merged 2 commits into from
Jun 4, 2019
Merged

Improve page rendering by deferring disqus loading #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a04c6
Improved page rendering by deferring disqus loading
KaitoHH Jun 1, 2019
98c3083
defer loading disqusJs
KaitoHH Jun 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions layout/_third-party/comments/disqus.swig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
{% if theme.disqus.count %}
<script id="dsq-count-scr" src="https://{{ theme.disqus.shortname }}.disqus.com/count.js" async></script>
<script>
function loadCount() {
var d = document, s = d.createElement('script');
s.src = 'https://{{ theme.disqus.shortname }}.disqus.com/count.js';
s.id = 'dsq-count-scr';
(d.head || d.body).appendChild(s);
}
// defer loading until the whole page loading is completed
window.addEventListener('load', loadCount, false);
</script>
{% endif %}
{% if page.comments %}
<script>
Expand All @@ -22,7 +31,7 @@
var offsetTop = $('#comments').offset().top - $(window).height();
if (offsetTop <= 0) {
// load directly when there's no a scrollbar
loadComments();
window.addEventListener('load', loadComments, false);
} else {
$(window).on('scroll.disqus_scroll', function() {
// offsetTop may changes because of manually resizing browser window or lazy loading images.
Expand All @@ -38,7 +47,7 @@
}
});
{% else %}
loadComments();
window.addEventListener('load', loadComments, false);
{% endif %}
</script>
{% endif %}
25 changes: 19 additions & 6 deletions layout/_third-party/comments/disqusjs.swig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,25 @@
{% if theme.vendors.disqusjs_js %}
{% set disqusjs_js_url = theme.vendors.disqusjs_js %}
{% endif %}
<script src="{{ disqusjs_js_url }}"></script>

<script>
var dsqjs = new DisqusJS({
api: '{{ theme.disqusjs.api }}' || 'https://disqus.com/api/',
apikey: '{{ theme.disqusjs.apikey }}',
shortname: '{{ theme.disqusjs.shortname }}'
});
function initialDsq() {
window.dsqjs = new DisqusJS({
api: '{{ theme.disqusjs.api }}' || 'https://disqus.com/api/',
apikey: '{{ theme.disqusjs.apikey }}',
shortname: '{{ theme.disqusjs.shortname }}',
url: {{ page.permalink | json }},
identifier: {{ page.path | json }},
title: '{{ page.title | addslashes }}',
});
}

function loadDsqJS() {
var d = document, s = d.createElement('script');
s.src = '{{ disqusjs_js_url }}';
s.onload = initialDsq;
(d.head || d.body).appendChild(s);
}

window.addEventListener('load', loadDsqJS, false);
</script>