Add detailed description about RSS#895
Merged
1v9 merged 2 commits intotheme-next:masterfrom Jun 3, 2019
xyyuhans:master
Merged
Add detailed description about RSS#8951v9 merged 2 commits intotheme-next:masterfrom xyyuhans:master
1v9 merged 2 commits intotheme-next:masterfrom
xyyuhans:master
Conversation
added 2 commits
June 3, 2019 12:14
I search the keyword "dependencies" to install dependencies in this config file, and I find that I forgot to install rss dependencies because there is no keyword "dependencies" in the description of rss. So I add the keyword "dependencies" to the description of rss.
auto-assign
bot
requested review from
ivan-nginx,
maple3142,
sli1989 and
stevenjoezhang
|
Thanks so much for opening your first PR here! |
|
|
stevenjoezhang
approved these changes
Jun 3, 2019
stevenjoezhang
changed the title
1v9
approved these changes
Jun 3, 2019
1v9
approved these changes
Jun 3, 2019
|
Congrats on merging your first pull request here! 🎉 How awesome! |
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I search the keyword "dependencies" to install dependencies in this config file, and I find that I forgot to install rss dependencies because there is no keyword "dependencies" in the description of rss.
What is the new behavior?
So I add the keyword "dependencies" to the description of rss.
Does this PR introduce a breaking change?