Group Pictures calculation by guopengd · Pull Request #929 · theme-next/hexo-theme-next

guopengd · 2019-06-25T07:40:27Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes was maked (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

What is the current behavior?

picture not loading properly

Issue resolved: N/A

What is the new behavior?

picture loaded correctly

Screenshots with this changes: N/A
Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:
none

Does this PR introduce a breaking change?

Yes.
No.

welcome · 2019-06-25T07:40:31Z

Thanks so much for opening your first PR here!

CLAassistant · 2019-06-25T07:40:36Z

All committers have signed the CLA.

1v9 · 2019-06-25T08:17:47Z

Any demo?

guopengd · 2019-06-25T08:31:13Z

My English is poor.Wait a moment,I make a demo.

…

------------------ 原始邮件 ------------------ 发件人: "1v9"<notifications@github.com>; 发送时间: 2019年6月25日(星期二) 下午4:17 收件人: "theme-next/hexo-theme-next"<hexo-theme-next@noreply.github.com>; 抄送: "郭鹏东"<648276765@qq.com>;"State change"<state_change@noreply.github.com>; 主题: Re: [theme-next/hexo-theme-next] Fix image line number calculationerror, the picture can not be fully loaded (#929) Any demo? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

guopengd · 2019-06-25T08:37:16Z

http://blog.gpdstudy.club/photos/ I want five lines,but four lines

…

------------------ 原始邮件 ------------------ 发件人: "1v9"<notifications@github.com>; 发送时间: 2019年6月25日(星期二) 下午4:17 收件人: "theme-next/hexo-theme-next"<hexo-theme-next@noreply.github.com>; 抄送: "郭鹏东"<648276765@qq.com>;"State change"<state_change@noreply.github.com>; 主题: Re: [theme-next/hexo-theme-next] Fix image line number calculationerror, the picture can not be fully loaded (#929) Any demo? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

guopengd · 2019-06-25T08:42:55Z

This is my code.

{% gp Defaults Layout %}
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
{% endgp %}

1v9 · 2019-06-25T10:19:41Z

I have a question, why your GP normal...

guopengd · 2019-06-25T10:31:42Z

ha? because my code hava "layout:post",this my code: ``` title: 图库 date: 2019-06-02 12:49:19 layout: post type: photos ```

…

------------------ 原始邮件 ------------------ 发件人: "ᴍɪᴍɪ"<notifications@github.com>; 发送时间: 2019年6月25日(星期二) 晚上6:14 收件人: "theme-next/hexo-theme-next"<hexo-theme-next@noreply.github.com>; 抄送: "郭鹏东"<648276765@qq.com>;"State change"<state_change@noreply.github.com>; 主题: Re: [theme-next/hexo-theme-next] Fix image line number calculationerror, the picture can not be fully loaded (#929) Wait... Group picture feature is gonna to be fully refactored. #713 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

1v9 · 2019-06-25T10:41:34Z

@guopengd It seems that you have some personal modifications.

guopengd · 2019-06-25T10:48:20Z

Maybe, I usr "fancybox" plug.（我用了插件fancybox）

…

------------------ 原始邮件 ------------------ 发件人: "1v9"<notifications@github.com>; 发送时间: 2019年6月25日(星期二) 晚上6:41 收件人: "theme-next/hexo-theme-next"<hexo-theme-next@noreply.github.com>; 抄送: "郭鹏东"<648276765@qq.com>;"Mention"<mention@noreply.github.com>; 主题: Re: [theme-next/hexo-theme-next] Fix image line number calculationerror, the picture can not be fully loaded (#929) @guopengd It seems that you have some personal modifications. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

guopengd · 2019-06-25T11:19:15Z

@1v9
哦，对了，因为group-pictures.style里面我看到两行代码，他禁止了浮动，我就把它删了。fancybox插件是为了增加图片查看的效果，我英语不好，不懂你问的什么意思。如果你是问排版为什么对，那是因为我删除了两行代码。如果是为什么我能放大图片，则是因为fancybox插件。这么长，我翻译不来

.page-post-detail .post-body .group-picture-column {
  // float: nowne;
  margin-top: 10px;
  // width: auto !important;
  img { margin: 0 auto; }
}

guopengd · 2019-06-25T11:30:22Z

@1v9

”photos“ setting:

---
layout: post
---

“group-pictures.styl' setting:

.page-post-detail .post-body .group-picture-column {
  // float: none;
  margin-top: 10px;
 // width: auto !important;
  img { margin: 0 auto; }
}

well,That can work normal.

1v9 · 2019-06-25T11:32:00Z

@guopengd 对的我是问排版，这个之前有过讨论了，不过我们团队好像都忘了 😂

guopengd · 2019-06-25T11:33:35Z

@1v9 哈哈，能中文交流就好，我英语太差了，四级都没过。其实就是你们在GP的css上设置了禁止float，我当时看也不知道用意在哪，就删了。然后在加载图片的时候，你们还加载了这个css，这波操作很迷

guopengd · 2019-06-25T11:49:05Z

@1v9 不能发地址，我把设置的代码发一下吧

---
title: 图库
date: 2019-06-02 12:49:19
layout: post
type: photos
---
{% gp Defaults Layout %}
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
![](https://images2.alphacoders.com/747/thumb-1920-747093.jpg)
{% endgp %}
<iframe frameborder="no" border="0" marginwidth="0" marginheight="0" width=330 height=86 src="//music.163.com/outchain/player?type=2&id=1368521705&auto=1&height=66"></iframe>

然后在“source/css/_common/components/tags/group-pictures.styl”的代码改为：

.post .post-body .group-picture {
  img {
    box-sizing: border-box;
    padding: 0 3px;
    border: none;
  }
}

.post .group-picture-row {
  overflow: hidden;
  margin-top: 6px;
  &:first-child { margin-top: 0; }
}

.post .group-picture-column { float: left; }

.page-post-detail .post-body .group-picture-column {
  // float: nowne;
  margin-top: 10px;
  // width: auto !important;
  img { margin: 0 auto; }
}

.page-archive {
  .group-picture-container { overflow: hidden; }
  .group-picture-row {
    float: left;
    &:first-child { margin-top: 6px; }
  }

  .group-picture-column {
    max-width: 150px;
    max-height: 150px;
  }
}

这样设置之后，布局就能正常显示了

welcome · 2019-07-03T03:16:29Z

Congrats on merging your first pull request here! 🎉 How awesome!

修复图片行号计算错误导致图片不能全部加载

a643739

auto-assign bot requested review from ivan-nginx, maple3142, sli1989 and stevenjoezhang June 25, 2019 07:40

guopengd changed the title ~~Fix image line number calculation error, the picture can not be fully loaded~~ {"must_include":{"regex":"change|feat|imp|fix|doc|i18n"}}{"no_empty":{"enabled":true}}Fix image line number calculation error, the picture can not be fully loaded Jun 25, 2019

guopengd changed the title ~~{"must_include":{"regex":"change|feat|imp|fix|doc|i18n"}}{"no_empty":{"enabled":true}}Fix image line number calculation error, the picture can not be fully loaded~~ Fix image line number calculation error, the picture can not be fully loaded Jun 25, 2019

guopengd closed this Jun 25, 2019

guopengd reopened this Jun 25, 2019

theme-next deleted a comment from guopengd Jun 25, 2019

1v9 mentioned this pull request Jun 25, 2019

Group Pictures layout #931

Merged

stevenjoezhang added the 🛠 Improvement label Jul 3, 2019

stevenjoezhang added this to the v7.3.0 milestone Jul 3, 2019

stevenjoezhang approved these changes Jul 3, 2019

View reviewed changes

stevenjoezhang merged commit 1f625a0 into theme-next:master Jul 3, 2019

stevenjoezhang mentioned this pull request Jul 3, 2019

Group Pictures bug? #713

Closed

1v9 changed the title ~~Fix image line number calculation error, the picture can not be fully loaded~~ Group Pictures calculation Jul 4, 2019

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019

Fix image line number calculation error (theme-next#929)

913fbf3

Conversation

guopengd commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

Uh oh!

welcome bot commented Jun 25, 2019

Uh oh!

CLAassistant commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1v9 commented Jun 25, 2019

Uh oh!

guopengd commented Jun 25, 2019 via email

Uh oh!

guopengd commented Jun 25, 2019 via email

Uh oh!

guopengd commented Jun 25, 2019

Uh oh!

1v9 commented Jun 25, 2019

Uh oh!

guopengd commented Jun 25, 2019 via email

Uh oh!

1v9 commented Jun 25, 2019

Uh oh!

guopengd commented Jun 25, 2019 via email

Uh oh!

guopengd commented Jun 25, 2019

Uh oh!

guopengd commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1v9 commented Jun 25, 2019

Uh oh!

guopengd commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guopengd commented Jun 25, 2019

Uh oh!

welcome bot commented Jul 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guopengd commented Jun 25, 2019 •

edited

Loading

CLAassistant commented Jun 25, 2019 •

edited

Loading

guopengd commented Jun 25, 2019 •

edited

Loading

guopengd commented Jun 25, 2019 •

edited

Loading