CSS selector change for plex-alt-logo.css#523
Merged
Conversation
GilbN
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Bug fixes
Description:
For the plex-alt-logo addon, it looks like Plex changed the class name that was used to select the Plex logo from
NavBar-plexLogo-*toNavBar-logoContainer-*. Currently, since the addon is still selecting the old class name the logo is not being replaced, so this PR is to fix that by updating the class name that is being selected.Benefits of this PR and context:
I didn't find any open issues for this, but the benefit here is that this change should fix the plex-alt-logo addon.
How Has This Been Tested?
I forked the project a couple of months ago and followed the instructions for enabling the plex-alt-logo addon. At the time it worked with no issues, but recently I noticed that my custom logo was not replacing the Plex logo anymore. In my forked project, I updated the plex-alt-logo CSS with the new class name and that fixed the issue for me.
Before:
After:
Source / References:
https://docs.theme-park.dev/themes/addons/plex/plex-alt-logo/