vuetorrent curl github redirect#535
Merged
Merged
Conversation
* Bad interpreter error associated with the NPM release of 2.9.21 (themepark-dev#486) * Fix Pi-Hole network details table colors (themepark-dev#489) * Grafana 9.5.1 element support (themepark-dev#492) Adding support for only a few elements in latest version of Grafana * Added uptime kuma card css (themepark-dev#494) * Use hashlib instead of git shas * Fix Latest manifest if logic --------- Co-authored-by: goodbyepavlyi 3 <pavlyi.off@gmail.com> Co-authored-by: Samuel Bartík <63553146+sambartik@users.noreply.github.com> Co-authored-by: rg9400 <39887349+rg9400@users.noreply.github.com> Co-authored-by: Henry Whitaker <36062479+henrywhitaker3@users.noreply.github.com>
* qbittorrent: 💄Fixes for themepark-dev#526 * Unraid: Fix login script github.io URL Unraid: Fix the navbar scroll overflow. * Move from subversion to git for pulling the qbittorrent webui (themepark-dev#530) * Move from subversion to git for pulling the qbittorrent webui * slight verbage changes --------- Co-authored-by: Blake <7227893+nintendo424@users.noreply.github.com>
The curl of the latest vuetorrent repo returns a 301 redirect code and location https://api.github.com/repositories/181508472/releases/latest resulting in a `Cannot iterate over null (null)` when jq filters assets against the output from the original request.
cjLGH
added a commit
to cjLGH/theme.park
that referenced
this pull request
Jan 26, 2024
Missed when reviewing themepark-dev#535
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Bug fixes
Current LSIO docker-mod
ghcr.io/themepark-dev/theme.park:vuetorrentfor qbittorrent has the output below when attempting to curl for theCURRENT_RELEASEvariable because of a redirect against https://api.github.com/repos/WDaan/VueTorrent/releases/latest.bash output from container during testing
Description:
The curl of the latest vuetorrent repo returns a 301 redirect code and location https://api.github.com/repositories/181508472/releases/latest resulting in a
Cannot iterate over null (null)when jq filters assets against the output from the original request. Adding the -L option to the curl command makes it follow a redirect.Benefits of this PR and context:
Current and future vuetorrent releases may get redirected.
How Has This Been Tested?
Manually.
Source / References:
https://curl.se/docs/manpage.html#-L