Fix for Javascrpt files that point to videos using broken subdomain gilbn.GitHub.io#676
Merged
GilbN merged 10 commits intoApr 18, 2025
Merged
Conversation
* Fix creation of themes.json
Deprecate arm7 builds, Bump versions on docker build workflow. Fix pl…
Fix publish job
Replacing "https://gilbn.github.io/theme.park/" with "https://theme-park.dev/" as former doesn't work anymore
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.
GilbN
requested changes
Apr 17, 2025
GilbN
left a comment
Collaborator
There was a problem hiding this comment.
Hi. Thanks for the PR. Can you update it to be https:\/\/theme-park.dev\/css\/addons\/ etc
Replaced "https://gilbn.github.io/theme.park/" in URL for video file, which is broken, to @GilbN preferred domain of "https://theme-park.dev/" Co-Authored-By: GilbN <24592972+GilbN@users.noreply.github.com>
Contributor
Author
|
Hi @GilbN, I'm a bit of a novice with source code repositories, and I made a bit of a mess when trying to get the changes uploaded the way I want, but hopefully it is all now showing the way you prefer, including the update of the video URL's to your preferred domain. |
GilbN
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Bug fixes
Description:
Replacing "https://gilbn.github.io/" with "https://themepark-dev.github.io/" in Javascript files as former doesn't work anymore, and the replacement domain is still hosted on GitHub.Benefits of this PR and context:
The video background won't work with the broken URL.
How Has This Been Tested?
Source / References: