Skip to content

Fix for Javascrpt files that point to videos using broken subdomain gilbn.GitHub.io#676

Merged
GilbN merged 10 commits into
themepark-dev:developfrom
KaHooli:js_files-gilbn.github.io-patch
Apr 18, 2025
Merged

Fix for Javascrpt files that point to videos using broken subdomain gilbn.GitHub.io#676
GilbN merged 10 commits into
themepark-dev:developfrom
KaHooli:js_files-gilbn.github.io-patch

Conversation

@KaHooli

@KaHooli KaHooli commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

theme-park.dev


  • I have read the contributing guideline and understand that I have made the correct modifications

  • PR's are done against the develop branch.


Bug fixes

  • When submitting bugfixes please show a before and after screenshot of the fix, and a description of what the fix does.

Description:

Replacing "https://gilbn.github.io/" with "https://themepark-dev.github.io/" in Javascript files as former doesn't work anymore, and the replacement domain is still hosted on GitHub.

Benefits of this PR and context:

The video background won't work with the broken URL.

How Has This Been Tested?

  • Tested in self hosted environment.
  • Unraid 7.0.1

Source / References:

  • Was discussed on Discord quite some time ago, and was encouraged to submit PR with fix.
  • Have submitted several PR's, closed all previous ones, as this one is most thorough as I've patched all four effected Javascript files.

GilbN and others added 9 commits October 14, 2024 21:54
* Fix creation of themes.json
Deprecate arm7 builds, Bump versions on docker build workflow. Fix pl…
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.
Replaced "https://gilbn.github.io/" in video file URL, which is broken, to "https://themepark-dev.github.io/", which does work.

@GilbN GilbN left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for the PR. Can you update it to be https:\/\/theme-park.dev\/css\/addons\/ etc

Replaced "https://gilbn.github.io/theme.park/" in URL for video file, which is broken, to @GilbN preferred domain of "https://theme-park.dev/"

Co-Authored-By: GilbN <24592972+GilbN@users.noreply.github.com>
@KaHooli

KaHooli commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

Hi @GilbN, I'm a bit of a novice with source code repositories, and I made a bit of a mess when trying to get the changes uploaded the way I want, but hopefully it is all now showing the way you prefer, including the update of the video URL's to your preferred domain.

@GilbN GilbN merged commit 1f6f9a9 into themepark-dev:develop Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants